Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cortex namespace python #230

Merged
merged 4 commits into from Jul 11, 2019
Merged

Cortex namespace python #230

merged 4 commits into from Jul 11, 2019

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Jul 11, 2019

Closes #205


Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)\
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged

@vishalbollu vishalbollu requested a review from deliahu July 11, 2019 15:35
@@ -1,5 +1,4 @@
- kind: api
name: fraud
model: @dnn
compute:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I feel like this should be a separate commit, so I just pushed that to master. Do you mind reverting it here and merging master?

@vishalbollu vishalbollu merged commit 4a7032f into master Jul 11, 2019
@vishalbollu vishalbollu deleted the cortex-namespace-python branch July 11, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Cortex Namespace to python modules
2 participants