Skip to content

Conversation

@vishalbollu
Copy link
Contributor


checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@vishalbollu vishalbollu requested review from deliahu and miguelvr July 23, 2021 14:52
Comment on lines 284 to 285
kubectl scale deployment operator-controller-manager --replicas=0 - >/dev/null
kubectl scale deployment operator-controller-manager --replicas=1 - >/dev/null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For restarting the operator pod, we delete the pod and let the deployment bring it back:

kubectl -n=default delete --ignore-not-found=true --grace-period=10 deployment operator >/dev/null 2>&1

Is there a reason you went with kubectl scale, and if so, should we change that one too?

@vishalbollu vishalbollu merged commit 44bb600 into master Jul 27, 2021
@vishalbollu vishalbollu deleted the refresh-cluster-config branch July 27, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants