Skip to content

Remove max_review_length aggregate from sentiment_dnn #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2019
Merged

Remove max_review_length aggregate from sentiment_dnn #50

merged 1 commit into from
Apr 5, 2019

Conversation

@vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Apr 5, 2019

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart local operator, and run cx refresh in an example folder)
  • Update documentation
  • Update examples and cx init
  • Alert team if dev environment changed
  • Cherry-pick into release branches if it's a bugfix
  • Delete the branch once it's merged

@deliahu deliahu merged commit 6738370 into master Apr 5, 2019
@vishalbollu vishalbollu deleted the clean-up-sentiment-dnn-review-example branch April 5, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deliahu deliahu deliahu approved these changes

@ospillinger ospillinger Awaiting requested review from ospillinger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vishalbollu @deliahu