Skip to content

Lower case nits and clean up cluster uninstall #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Lower case nits and clean up cluster uninstall #599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/cmd/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ var downCmd = &cobra.Command{
errors.Exit(err)
}

prompt.YesOrExit("are you sure you want to uninstall cortex? (your cluster will be spun down and all apis will be deleted)", "")
prompt.YesOrExit("your cluster will be spun down and all apis will be deleted, are you sure you want to uninstall cortex?", "")

awsCreds, err := getAWSCredentials(flagClusterConfig)
if err != nil {
Expand Down
6 changes: 3 additions & 3 deletions pkg/lib/clusterconfig/config_key.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,15 @@ const (
InstanceDistributionUserFacingKey = "spot instance distribution"
OnDemandBaseCapacityUserFacingKey = "spot on demand base capacity"
OnDemandPercentageAboveBaseCapacityUserFacingKey = "spot on demand percentage above base capacity"
MaxPriceUserFacingKey = "spot max price (USD per hour)"
MaxPriceUserFacingKey = "spot max price ($ per hour)"
InstancePoolsUserFacingKey = "spot instance pools"
LogGroupUserFacingKey = "CloudWatch log group"
LogGroupUserFacingKey = "cloudwatch log group"
TelemetryUserFacingKey = "telemetry"
ImagePredictorServeUserFacingKey = "predictor serving image"
ImagePredictorServeGPUUserFacingKey = "predictor serving gpu image"
ImageTFServeUserFacingKey = "tensorflow serving image"
ImageTFServeGPUUserFacingKey = "tensorflow serving gpu image"
ImageTFAPIUserFacingKey = "tensorflow API image"
ImageTFAPIUserFacingKey = "tensorflow api image"
ImageONNXServeUserFacingKey = "onnx serving image"
ImageONNXServeGPUUserFacingKey = "onnx serving gpu image"
ImageOperatorUserFacingKey = "operator image"
Expand Down