Skip to content

Update instance pools key and Instance distribution change check #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2019
Merged

Update instance pools key and Instance distribution change check #613

merged 1 commit into from
Nov 28, 2019

Conversation

vishalbollu
Copy link
Contributor

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cortex deploy --refresh)
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged

@vishalbollu vishalbollu requested a review from deliahu November 28, 2019 03:33
@vishalbollu vishalbollu merged commit 9ee1678 into master Nov 28, 2019
vishalbollu added a commit that referenced this pull request Nov 28, 2019
@vishalbollu
Update instance pools key and Instance distribution change check (#613)
01bc431 
(cherry picked from commit 9ee1678)
@deliahu deliahu deleted the instance-distribution-instance-pool-naming branch November 28, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishalbollu @deliahu