Update docs #706
Merged
Update docs #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deliahu
approved these changes
Dec 24, 2019
cli/cmd/lib_cluster_config.go
Outdated
| if clusterConfig.Spot != nil && *clusterConfig.Spot { | ||
| if *clusterConfig.SpotConfig.OnDemandBaseCapacity == 0 && *clusterConfig.SpotConfig.OnDemandPercentageAboveBaseCapacity == 0 { | ||
| fmt.Println(fmt.Sprintf("WARNING: you've disabled on-demand instances (%s=0 and %s=0); spot instances are not guaranteed to be available so please take that into account for production clusters", clusterconfig.OnDemandBaseCapacityKey, clusterconfig.OnDemandPercentageAboveBaseCapacityKey)) | ||
| fmt.Println(fmt.Sprintf("WARNING: you've disabled on-demand instances (%s=0 and %s=0); spot instances are not guaranteed to be available so please take that into account for production clusters; see https://www.cortex.dev/v/%s/cluster-management/spot-instances for more information", clusterconfig.OnDemandBaseCapacityKey, clusterconfig.OnDemandPercentageAboveBaseCapacityKey, consts.CortexVersionMinor)) |
Member
There was a problem hiding this comment.
This should be fmt.Printf with a \n at the end
cli/cmd/lib_cluster_config.go
Outdated
| fmt.Println(fmt.Sprintf("WARNING: you've disabled on-demand instances (%s=0 and %s=0); spot instances are not guaranteed to be available so please take that into account for production clusters; see https://www.cortex.dev/v/%s/cluster-management/spot-instances for more information", clusterconfig.OnDemandBaseCapacityKey, clusterconfig.OnDemandPercentageAboveBaseCapacityKey, consts.CortexVersionMinor)) | ||
| } else { | ||
| fmt.Println("WARNING: you've enabled spot instances; spot instances are not guaranteed to be available so please take that into account for production clusters") | ||
| fmt.Println("WARNING: you've enabled spot instances; spot instances are not guaranteed to be available so please take that into account for production clusters; see https://www.cortex.dev/v/%s/cluster-management/spot-instances for more information", consts.CortexVersionMinor) |
Member
There was a problem hiding this comment.
This should be fmt.Printf with a \n at the end
|
|
||
| <br> | ||
|
|
||
| * Pricing is for the US West (Oregon) AWS region. |
Member
There was a problem hiding this comment.
Mention that this on demand pricing? Also maybe link to the spot docs (I feel less strongly about that)
|
|
||
| ## G4 instances | ||
|
|
||
| [G4 instances](https://aws.amazon.com/ec2/instance-types/g4/) are useful for clusters that primarily run model inferences with high compute and low memory resource utilization. |
Member
There was a problem hiding this comment.
Models also need to be able to take advantage of the GPU, so maybe at the end add something like “, and can run on a GPU”
|
|
||
| ## P2 instances | ||
|
|
||
| [P2 instances](https://aws.amazon.com/ec2/instance-types/p2/) are useful for clusters that primarily run model inferences with high compute and high memory resource utilization. |
Member
There was a problem hiding this comment.
Same comment as above regarding the GPU
|
|
||
| * Example: [language identification](../../examples/pytorch/language-identifier) using PyTorch | ||
| * Compute: high | ||
| * Memory: low |
vishalbollu
reviewed
Dec 24, 2019
cli/cmd/lib_cluster_config.go
Outdated
| if clusterConfig.Spot != nil && *clusterConfig.Spot { | ||
| if *clusterConfig.SpotConfig.OnDemandBaseCapacity == 0 && *clusterConfig.SpotConfig.OnDemandPercentageAboveBaseCapacity == 0 { | ||
| fmt.Println(fmt.Sprintf("WARNING: you've disabled on-demand instances (%s=0 and %s=0); spot instances are not guaranteed to be available so please take that into account for production clusters", clusterconfig.OnDemandBaseCapacityKey, clusterconfig.OnDemandPercentageAboveBaseCapacityKey)) | ||
| fmt.Printf(fmt.Sprintf("WARNING: you've disabled on-demand instances (%s=0 and %s=0); spot instances are not guaranteed to be available so please take that into account for production clusters; see https://www.cortex.dev/v/%s/cluster-management/spot-instances for more information\n", clusterconfig.OnDemandBaseCapacityKey, clusterconfig.OnDemandPercentageAboveBaseCapacityKey, consts.CortexVersionMinor)) |
Contributor
There was a problem hiding this comment.
The inner fmt.Sprintf can be removed
vishalbollu
approved these changes
Dec 24, 2019
ospillinger
force-pushed
the
update-docs
branch
from
d9a70c3 to
41e9d48
Compare
vishalbollu
approved these changes
Dec 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.