Skip to content

Prevent cx up on duplicate cluster #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 24, 2019
Merged

Prevent cx up on duplicate cluster #708

merged 2 commits into from
Dec 24, 2019

Conversation

@vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Dec 24, 2019

checklist:

  • run make test and make lint
  • test end to end manually (i.e. build/push all images, restart operator, and run cortex deploy --refresh)
  • update the examples
  • update the docs and add any new files to summary.md
  • merge to master
  • cherry-pick into release branches if applicable
  • check that the docs are up-to-date in gitbook
  • alert the dev team if the dev environment changed
  • delete the branch once it's merged

@vishalbollu vishalbollu requested a review from deliahu December 24, 2019 23:33
@vishalbollu vishalbollu merged commit b13c112 into master Dec 24, 2019
@vishalbollu vishalbollu deleted the prevent-cx-up-on-duplicate-cluster branch December 24, 2019 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deliahu deliahu Awaiting requested review from deliahu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vishalbollu