Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused /validate_expr endpoint. #2152

Merged
merged 2 commits into from Feb 18, 2020
Merged

Remove unused /validate_expr endpoint. #2152

merged 2 commits into from Feb 18, 2020

Conversation

pstibrany
Copy link
Contributor

What this PR does: This PR removes unused /validate_expr endpoint, introduced by #184. It has never been used, and is not documented, and its output is changing because of changes in Prometheus error reporting (#2088 for details). Instead of fixing it, let's remove it. (If we need it again, we can introduce it again).

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pracucci pracucci merged commit 1d3614b into cortexproject:master Feb 18, 2020
@pstibrany pstibrany mentioned this pull request Feb 19, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants