Fix flaky TestIngester_flushing #3406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codesome
commented
Oct 28, 2020
pkg/ingester/ingester_v2_test.go
Outdated
Contributor
Author
There was a problem hiding this comment.
This sleep it similar to what we are doing above for other test cases. Additionally added polling for other cases.
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
codesome
force-pushed
the
fix-flaky-test
branch
from
7444341 to
c57a74e
Compare
gouthamve
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes the flaky test
TestIngester_flushingWhich issue(s) this PR fixes:
Fixes #3404
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]