Changed default value of -blocks-storage.bucket-store.sync-interval from 5m to 15m #3724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orm 5m to 15m Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
While rolling out the bucket index in our cluster we've realised the default value of
-blocks-storage.bucket-store.sync-interval(5m) doesn't play nicely with the consistency check. The consistency check gives a grace period for blocks recently uploaded (and potentially not yet discovered by store-gateway) which is equal to 3x the sync-interval (so 15m by default). Considering a default caching TTL for the bucket index of 5m, there may be edge cases where the querier is including a recently uploaded block in the consistency check but the store-gateway hasn't loaded it yet.To fix the default config, in this PR I'm proposing to increase the default value of
sync-intervalfrom 5m to 15m (which also look a better default value anyway).Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]