From 5efebfdbc80c96afa0d0d718a0ce0a925e678c29 Mon Sep 17 00:00:00 2001 From: SungJin1212 Date: Fri, 26 Sep 2025 11:28:10 +0900 Subject: [PATCH] Fix flaky TestPerLabelsetDiscardedSeriesTracker Signed-off-by: SungJin1212 --- pkg/util/discardedseries/perlabelset_tracker.go | 2 +- pkg/util/discardedseries/perlabelset_tracker_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/util/discardedseries/perlabelset_tracker.go b/pkg/util/discardedseries/perlabelset_tracker.go index d2098117816..1d5e0a9a158 100644 --- a/pkg/util/discardedseries/perlabelset_tracker.go +++ b/pkg/util/discardedseries/perlabelset_tracker.go @@ -81,9 +81,9 @@ func (t *DiscardedSeriesPerLabelsetTracker) Track(user string, series uint64, ma func (t *DiscardedSeriesPerLabelsetTracker) UpdateMetrics() { usersToDelete := make([]string, 0) - labelsetsToDelete := make([]uint64, 0) t.RLock() for user, labelsetCounter := range t.userLabelsetMap { + labelsetsToDelete := make([]uint64, 0) labelsetCounter.RLock() if len(labelsetCounter.labelsetSeriesMap) == 0 { usersToDelete = append(usersToDelete, user) diff --git a/pkg/util/discardedseries/perlabelset_tracker_test.go b/pkg/util/discardedseries/perlabelset_tracker_test.go index 849f987fb11..4b0696f6e10 100644 --- a/pkg/util/discardedseries/perlabelset_tracker_test.go +++ b/pkg/util/discardedseries/perlabelset_tracker_test.go @@ -114,5 +114,5 @@ func TestPerLabelsetDiscardedSeriesTracker(t *testing.T) { func comparePerLabelsetSeriesVendedCount(t *testing.T, gaugeVec *prometheus.GaugeVec, user string, labelsetLimitId string, val int) { gauge, _ := gaugeVec.GetMetricWithLabelValues("per_labelset_series_limit", user, labelsetLimitId) - require.Equal(t, testutil.ToFloat64(gauge), float64(val)) + require.Equal(t, float64(val), testutil.ToFloat64(gauge)) }