Add type and unit labels to prw2 #7077
Conversation
SungJin1212
force-pushed
the
Add-type-and-unit-labels-to-prw2
branch
from
c14d273 to
5ab3a6a
Compare
| # EXPERIMENTAL: If true, the __type__ and __unit__ labels are added to metrics. | ||
| # This only applies to remote write v2 requests. | ||
| # CLI flag: -distributor.rw2-enable-type-and-unit-labels |
There was a problem hiding this comment.
Do we need to mention rw2 in the config name? I would align the config name with Prometheus and callout that this feature is only for RW2 in the description.
There was a problem hiding this comment.
Then this flag has same name with the -distributor.otlp.enable-type-and-unit-labels field. Doesn't it matter?
There was a problem hiding this comment.
My concern is that users don't know what rw2 means. We should avoid using abbreviations in the config name. I think it should be ok to use 1 flag to control both. Maybe we can unify to be distributor.enable-type-and-unit-labels?
There was a problem hiding this comment.
I add -distributor.enable-type-and-unit-labels flag which works for OTLP and PRW2. I think this PR should be included in version 1.20.
CHANGELOG.md
Outdated
| * [FEATURE] Querier: Support for configuring query optimizers and enabling XFunctions in the Thanos engine. #6873 | ||
| * [FEATURE] Query Frontend: Add support /api/v1/format_query API for formatting queries. #6893 | ||
| * [FEATURE] Query Frontend: Add support for /api/v1/parse_query API (experimental) to parse a PromQL expression and return it as a JSON-formatted AST (abstract syntax tree). #6978 | ||
| * [FEATURE] Distributor: Add a per-tenant flag `-distributor.rw2-enable-type-and-unit-labels` which enables to add `__unit__` and `__type__` labels for remote write v2 requests. #7077 |
There was a problem hiding this comment.
Can you please move the changelog to unreleased section?
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
Add-type-and-unit-labels-to-prw2
branch
from
5ab3a6a to
bacadc7
Compare
2 participants
Add a per-tenant flag
-distributor.enable-type-and-unit-labelswhich enables to add__unit__and__type__labels for remote write v2 and OTLP requests.Which issue(s) this PR fixes:
Fixes #7059
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]