From ed89ff6e917c3a0c86af7fbed38c77a273c53aa4 Mon Sep 17 00:00:00 2001 From: Ben Ye Date: Mon, 11 May 2026 03:19:37 +0000 Subject: [PATCH] fix: increase WaitActiveInstanceTimeout in TestCompactor_RingLifecyclerShouldAutoForgetUnhealthyInstances The test was flaky because WaitActiveInstanceTimeout (5s from prepareConfig) was too tight when combined with WaitStabilityMinDuration=1s and WaitStabilityMaxDuration=5s. On slow CI machines, the ring lifecycler may not transition to ACTIVE within 5s, causing a context deadline exceeded error at StartAndAwaitRunning. Increase WaitActiveInstanceTimeout to 30s to give sufficient headroom for the ring to stabilize on slow CI environments. Signed-off-by: Ben Ye --- pkg/compactor/compactor_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/compactor/compactor_test.go b/pkg/compactor/compactor_test.go index dff52d9695c..ec30a739004 100644 --- a/pkg/compactor/compactor_test.go +++ b/pkg/compactor/compactor_test.go @@ -2201,6 +2201,7 @@ func TestCompactor_RingLifecyclerShouldAutoForgetUnhealthyInstances(t *testing.T cfg.ShardingRing.InstanceAddr = fmt.Sprintf("127.0.0.%d", i) cfg.ShardingRing.WaitStabilityMinDuration = time.Second cfg.ShardingRing.WaitStabilityMaxDuration = 5 * time.Second + cfg.ShardingRing.WaitActiveInstanceTimeout = 30 * time.Second cfg.ShardingRing.KVStore.Mock = kvstore cfg.ShardingRing.HeartbeatPeriod = 200 * time.Millisecond cfg.ShardingRing.UnregisterOnShutdown = false