From 4f03a7d271a49dc62fa28e036c60a11ebd0a3ef3 Mon Sep 17 00:00:00 2001 From: Cory House Date: Wed, 28 Feb 2018 05:44:01 -0800 Subject: [PATCH] Create PULL_REQUEST_TEMPLATE.md --- PULL_REQUEST_TEMPLATE.md | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 PULL_REQUEST_TEMPLATE.md diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 000000000..4f31b6652 --- /dev/null +++ b/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,24 @@ +The code review checklist below is used for all pull requests. + + 1. Review the list before submitting your pull request. + 2. Leave the list intact for the code reviewer's use. + +Thanks! :) + +## Code Review Checklist + +- [ ] Latest code from master has been merged into the pull request branch +- [ ] Honors [the seven code virtues](https://pragprog.com/magazines/2011-08/how-virtuous-is-your-code) + - [ ] Working, as opposed to incomplete + - [ ] Unique, as opposed to duplicated + - [ ] Simple, as opposed to complicated + - [ ] Clear, as opposed to puzzling + - [ ] Easy, as opposed to difficult + - [ ] Developed, as opposed to primitive + - [ ] Brief, as opposed to chatty +- [ ] Code is camelCased +- [ ] No commented out code (if required, place // TODO above with explanation) +- [ ] No linting issues +- [ ] Automated tests exist and pass +- [ ] Build is successful (`npm run build`) +- [ ] Works in IE 11, Chrome, Firefox, and Edge