Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x5t hashAlg as a name or just a value #46

Open
BrianSipos opened this issue Feb 9, 2022 · 2 comments
Open

x5t hashAlg as a name or just a value #46

BrianSipos opened this issue Feb 9, 2022 · 2 comments

Comments

@BrianSipos
Copy link

@BrianSipos BrianSipos commented Feb 9, 2022

The current COSE X509 spec defines the x5t algorithm identifier as:

corresponding to either the Value (integer) or Name (string) column of the algorithm registered in the "COSE Algorithms" registry

I think that this definition has a misunderstanding of the form of the IANA registry. The registry "Value" column can either be an int or a tstr but none of the current items in the registry happen to have a tstr value. Notice the "Range" table above the item table.

My interpretation agrees with the tooling that I've had some experience with; the "Name" column of the IANA tables is informational only, it may be part of diagnostic display but it is never compared to encoded values.

If this is the case, then the COSE X509 text should read:

corresponding to the Value column (integer or text string) of the algorithm registered in the "COSE Algorithms" registry

@cabo
Copy link
Contributor

@cabo cabo commented Mar 21, 2022

From the horse's (RFC 8152) mouth:

   Name:  A value that can be used to identify an algorithm in documents
      for easier comprehension.  The name SHOULD be unique.  However,
      the 'Value' field is what is used to identify the algorithm, not
      the 'name' field.

   Value:  The value to be used to identify this algorithm.  Algorithm
      values MUST be unique.  The value can be a positive integer, a
      negative integer, or a string.  Integer values between -256 and
      255 and strings of length 1 are designated as "Standards Action".
      Integer values from -65536 to 65535 and strings of length 2 are
      designated as "Specification Required".  Integer values greater
      than 65535 and strings of length greater than 2 are designated as
      "Expert Review".  Integer values less than -65536 are marked as
      private use.

So there should be no mention of "Name" when it comes to data on the wire.

@paulwouters
Copy link

@paulwouters paulwouters commented May 13, 2022

So it seems this change should still be applied to draft-ietf-cose-x509-08 ? Can one of the WG chairs do this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants