New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't treat $^O darwin (MacOS) like Win32 #17

Merged
merged 1 commit into from Mar 12, 2016

Conversation

Projects
None yet
2 participants
@jmaslak
Contributor

jmaslak commented Mar 4, 2016

This allows the module to install properly on MacOS. The Makefile was using $^O to determine if Win32::SerialPort was needed with a grep for case-insensitive "win" in $^O. This wrongly detected "darwin" (the $^O value for MacOS) as Windows.

There are a few ways this could have been done, this is just one possibility, but I believe it will do the right thing on Win.*, cygwin, and darwin now.

@jmaslak

This comment has been minimized.

Show comment
Hide comment
@jmaslak

jmaslak Mar 5, 2016

Contributor

Note that the Travis CI builds failed because of the problem fixed in #16, not because of anything in this PR.

Contributor

jmaslak commented Mar 5, 2016

Note that the Travis CI builds failed because of the problem fixed in #16, not because of anything in this PR.

cosimo added a commit that referenced this pull request Mar 12, 2016

Merge pull request #17 from jmaslak/fix-macos-os-detection
Don't treat $^O darwin (MacOS) like Win32

@cosimo cosimo merged commit 5119e4e into cosimo:master Mar 12, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@cosimo

This comment has been minimized.

Show comment
Hide comment
@cosimo

cosimo Mar 12, 2016

Owner

Thanks! I would be surprised if Device::Gsm worked on Mac OS X, though :-)

Owner

cosimo commented Mar 12, 2016

Thanks! I would be surprised if Device::Gsm worked on Mac OS X, though :-)

@jmaslak

This comment has been minimized.

Show comment
Hide comment
@jmaslak

jmaslak Mar 13, 2016

Contributor

I've been doing most of my work on OS X, without any trouble - other than this issue, it worked out of the box. :) Thanks for merging - expect to see some other stuff (unicode, Adafruit Fona, possibly long message support) later this week or early next.

Contributor

jmaslak commented Mar 13, 2016

I've been doing most of my work on OS X, without any trouble - other than this issue, it worked out of the box. :) Thanks for merging - expect to see some other stuff (unicode, Adafruit Fona, possibly long message support) later this week or early next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment