New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed tests due to logic error in t/08storage.t #18

Merged
merged 1 commit into from Mar 12, 2016

Conversation

Projects
None yet
2 participants
@jmaslak
Contributor

jmaslak commented Mar 5, 2016

This test failed when run with $ENV{DEV_GSM_PORT} defined and a real module connected. There were a couple of logic errors - First, there were two cases where the return value of $obj->storage() should have been used but wasn't. The other error was that only 7 tests are executed with a module connected, but the test plan indicated 8 - I fixed this and adjusted the skip value to 5 from 6 when testing without a module connected, so those tests continue to pass as well.

I expect this to fail the TravisCI build because of the problems #16 corrects - if both this pull request and the one referenced are merged, this will be able to pass TravisCI properly.

Fix failed tests due to logic error in test when run with
$ENV{DEV_GSM_PORT} defined and a real module connected

cosimo added a commit that referenced this pull request Mar 12, 2016

Merge pull request #18 from jmaslak/fix-08storage-test-fail
Fix failed tests due to logic error in t/08storage.t

@cosimo cosimo merged commit 8c97b03 into cosimo:master Mar 12, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@cosimo

This comment has been minimized.

Show comment
Hide comment
@cosimo

cosimo Mar 12, 2016

Owner

I have never been able to fully test the storage feature for lack of compliant devices :-)

Owner

cosimo commented Mar 12, 2016

I have never been able to fully test the storage feature for lack of compliant devices :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment