New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memoize command test #19

Merged
merged 2 commits into from Mar 12, 2016

Conversation

Projects
None yet
2 participants
@jmaslak
Contributor

jmaslak commented Mar 6, 2016

It's not actually using memoize, but it is caching the results of the test_command after it is executed once for a given session (each object has its' own cache, and the cache is cleared on connect() or disconnect()). This isn't necessarily a complete replacement for the profiles "todo" in the POD, but I believe it probably is a better solution since it can adapt to whatever next week's new device is without having to push a new package.

Note that without pull request #16 merged this will not pass tests but it passes fine once the tests are corrected.

cosimo added a commit that referenced this pull request Mar 12, 2016

@cosimo cosimo merged commit eba7032 into cosimo:master Mar 12, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@cosimo

This comment has been minimized.

Show comment
Hide comment
@cosimo

cosimo Mar 12, 2016

Owner

Good idea!

Owner

cosimo commented Mar 12, 2016

Good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment