New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utf16 support #22

Open
wants to merge 16 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@jmaslak
Contributor

jmaslak commented Mar 20, 2016

This is the big PR - adding UTF16 (emoticons, etc) support to the module. I did some general Unicode tune-up of various test files (converting the non-UTF8 encodings to be more standard UTF8 for easier editing).

I do not believe that I broke the old API in a significant way, although I do switch to UCS2 charset mode, if the phone is in PDU mode, when send_sms() is passed a message that can't cleanly convert to GSM0338.

I also added in examples a send_csms.pl script which I'm using for my personal purposes right now. It doesn't have any locking, but enables sending CSMS from the command line easily (inside of scripts
and the like).

I'm open to any discussion or thoughts you might have on this - so feel free to suggest I do things somewhat differently or using a different approach, if it would work better with this module in your eyes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment