New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default c++ compiler to "c++" #7

Merged
merged 1 commit into from May 12, 2015

Conversation

Projects
None yet
2 participants
@bjakubski
Contributor

bjakubski commented May 10, 2015

This tiny change implements SREZIC suggestion from https://rt.cpan.org/Public/Bug/Display.html?id=99810
It appears to work (Text::Hunspell with that fix passed "make test" on virtualboxed FreeBSD 10).

@cosimo

This comment has been minimized.

Show comment
Hide comment
@cosimo

cosimo May 12, 2015

Owner

How about the following?

use Config;
my $CC = $ENV{'CXX'} || $Config{cpp} || 'c++';
Owner

cosimo commented May 12, 2015

How about the following?

use Config;
my $CC = $ENV{'CXX'} || $Config{cpp} || 'c++';
@bjakubski

This comment has been minimized.

Show comment
Hide comment
@bjakubski

bjakubski May 12, 2015

Contributor

@cosimo
I don't think there is "C++ compiler name" available in Config.
And "cpp" there seems to be C preprocessor :-)

I think using ExtUtils::CppGuess (it actually is about C++, not cpp) might be best idea here.

Contributor

bjakubski commented May 12, 2015

@cosimo
I don't think there is "C++ compiler name" available in Config.
And "cpp" there seems to be C preprocessor :-)

I think using ExtUtils::CppGuess (it actually is about C++, not cpp) might be best idea here.

@cosimo

This comment has been minimized.

Show comment
Hide comment
@cosimo

cosimo May 12, 2015

Owner

That's right. I confused the preprocessor with compiler :)

Owner

cosimo commented May 12, 2015

That's right. I confused the preprocessor with compiler :)

cosimo added a commit that referenced this pull request May 12, 2015

Merge pull request #7 from bjakubski/compiler-freebsd
change default c++ compiler to "c++"

@cosimo cosimo merged commit beb88d8 into cosimo:master May 12, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cosimo

This comment has been minimized.

Show comment
Hide comment
@cosimo

cosimo May 12, 2015

Owner

Ok, so my decision is to accept the PR anyway, since it improves on the original "g++", and eventually later on use ExtUtils::CppGuess.

Owner

cosimo commented May 12, 2015

Ok, so my decision is to accept the PR anyway, since it improves on the original "g++", and eventually later on use ExtUtils::CppGuess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment