Update lib/LWP/Simple.pm #14

Merged
merged 1 commit into from Jul 30, 2012

Projects

None yet

2 participants

@ronaldxs
Contributor

Had an IRC chat with moritz. He thought my coding wasn't so bad but didn't fit with the surrounding code and suggested this instead. During the discussion it also came up that recv doesn't support binary very well yet but $socket.read(nnnn) does. It occurs to me that since HTTP headers often have a Content-length the read solution may be good in the nearish future.

@ronaldxs ronaldxs Update lib/LWP/Simple.pm
Had an IRC chat with moritz.  He thought my coding wasn't so bad but didn't fit with the surrounding code and suggested this instead.  During the discussion it also came up that recv doesn't support binary very well yet but $socket.read(nnnn) does.  It occurs to me that since HTTP headers often have a Content-length the read solution may be good in the nearish future.
5c040e0
@cosimo cosimo merged commit cd484d8 into cosimo:master Jul 30, 2012
Owner
cosimo commented Jul 30, 2012

I can understand this better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment