-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove blob dependency in absorption #76
Conversation
…cy_absorption Remove blob dependency in absorption (Sourcery refactored)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.78%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Let us know what you think of it by mentioning @sourcery-ai in a comment. |
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
+ Coverage 93.39% 93.97% +0.58%
==========================================
Files 30 30
Lines 1725 1727 +2
==========================================
+ Hits 1611 1623 +12
+ Misses 114 104 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This PR removes the dependency, in the absorption class, from any
Blob
object.More clearly, I have replaced
Absorption(blob, target, r)
->Absorption(target, r, z, mu_s)
z=0
by default andmu_s=1
, such that one is automatically in the blazar scenario.I have updated the documentation accordingly, I will comment in the pertaining issues where results have actually improved.
Incidentally, I have removed the
crosscheck
folder, and added it to the.gitignore
.I think it does not make sense to store all those pngs in github, they can be inspected locally after running the tests.
Additionally the check on the deviation from the reference models is performed automatically by
np.allclose
.