fix: responsive DocSearch-Button #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hungdinh82
changed the title
julienrbrt
approved these changes
Feb 18, 2025
Contributor
Author
|
Is there any problem with my PR? @julienrbrt |
Contributor
|
I don't have rights in the comos repos anymore to merge this. |
Contributor
Author
|
So now, who can I tag to merge this PR? |
Contributor
Author
|
@samricotta @tac0turtle Can you review it for me? |
Contributor
Author
|
Can you tell me who currently has the permission to merge PRs for me? @julienrbrt |
aljo242
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@julienrbrt
I noticed an issue with the navbar layout when the screen is below 997px. At that point, the DocSearch-Button was overlapping with the hamburger menu as shown in the image below:
I have fixed it: