Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposer address to governance proposal #10932

Closed
4 tasks
sunnya97 opened this issue Jan 11, 2022 · 4 comments
Closed
4 tasks

Add proposer address to governance proposal #10932

sunnya97 opened this issue Jan 11, 2022 · 4 comments
Assignees
Labels

Comments

@sunnya97
Copy link
Member

sunnya97 commented Jan 11, 2022

Summary

When we first created the x/gov module, we chose to purposefully not store the proposer in a governance proposal under this high-minded idealism that "when evaluating a governance proposal, the proposer should not matter, only the content".

However, in practice, we've seen that basically every single block explorer has chosen to prominently display the proposer, fetching it from the tx data of the proposal. Given that this is the case, we might as well include the proposer into the proposal struct, so that its easier to fetch this data and integrate with.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@faddat
Copy link
Contributor

faddat commented Jan 12, 2022

This makes sense.

Additionally, the proposer does matter:

I take a proposal from someone I know much more seriously than one from a throwaway wallet loaded with only enough to make a deposit.

@ctrl-Felix
Copy link

Is there any update on this?

I think it would be very useful.

@alexanderbez
Copy link
Contributor

There is no open PR. But the work is trivial, but it is state machine breaking. So we need to decide if we want this in the next release (v0.47).

cc @marbar3778

@tac0turtle
Copy link
Member

done and back ported to 0.47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants