Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coin metadata #1980

Open
sunnya97 opened this issue Aug 10, 2018 · 8 comments

Comments

Projects
None yet
5 participants
@sunnya97
Copy link
Member

commented Aug 10, 2018

Bank module should have a store that keeps metadata about different denoms.
Examples:

  • decimals per denom
  • is allowed to transfer through IBC
  • max total supply (?)

@sunnya97 sunnya97 self-assigned this Aug 10, 2018

@fedekunze

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2018

Interesting proposal @sunnya97. Should we also add the origin zone where the coins get minted ?

@sunnya97

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2018

Yeah, maybe we can put the the IBC transfer path prefixing (#842) as a metadata property, so the token name doesn't have to grow super large.

@rigelrozanski

This comment has been minimized.

Copy link
Member

commented Aug 27, 2018

Based on a previous discussion, we decided this was postlaunch, as we already keep track of the total supply for atoms in staking - which is the only total supply we'll need to know at launch

@fedekunze

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

blocked by #3972

@fedekunze fedekunze added the blocked label Apr 4, 2019

@fedekunze fedekunze referenced this issue May 27, 2019

Merged

R4R: Supply Module #4255

3 of 8 tasks complete

@fedekunze fedekunze assigned fedekunze and unassigned sunnya97 May 27, 2019

@jackzampolin

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

Good pick up @fedekunze

@fedekunze

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

As @sunnya97 explained to me the other day, #4255 doesn't address this issue. This will have to be spec'ed out prior to implementation

@fedekunze fedekunze removed the blocked label Jun 28, 2019

@fedekunze fedekunze changed the title Add Denom Metadata to bank module Coin metadata Jun 28, 2019

@fedekunze

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

I think this metadata also could apply to NFTs (cc: @okwme @marbar3778). Maybe it makes sense to have an Asset interface which NFT and coins also comply with

@okwme

This comment has been minimized.

Copy link

commented Jun 28, 2019

I'd be really into a separation of asset and metadata. I think the fungible and non-fungible token should do only what they're meant to do: represent an asset with denomination (+origin chain) and amount (ID in the case of NFTs). The metadata should be linked to the generalized asset type of fungible or non-fungible token and should be able to have as much or as little depth as needed.

I'm kind of into the schema.org way of nested categorization:
https://schema.org/docs/full.html

Assets could use this format as well as some way of describing which aspects of this format they satisfy. There could also be a protocol for expanding the schema with versions that various projects could keep in sync with.

For games:
https://schema.org/VideoGame
General assets NFT or otherwise:
https://schema.org/TypeAndQuantityNode
Currency:
https://schema.org/currency (maybe needs to be extended)

As a standard used outside of our specific context with an organization dedicated to it it might be good as a common denominator between all sorts of assets which require metadata

https://github.com/schemaorg/schemaorg

@okwme okwme referenced this issue Jun 28, 2019

Open

NFT Module #4046

0 of 4 tasks complete

@fedekunze fedekunze removed the post-launch label Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.