New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game of Stakes / gaia-9002 release checklist #2754

Closed
jackzampolin opened this Issue Nov 9, 2018 · 7 comments

Comments

Projects
None yet
7 participants
@jackzampolin
Copy link
Contributor

jackzampolin commented Nov 9, 2018

Tendermint Changes:

The following PRs are absolutely, unequivocally, indisputably required:

The following PRs may need to be merged for Game of Stakes:

  • #2872 - Debug leftover distribution coins on export
  • #2839 - Gas uint64 (R4R)
  • #2807 - Runtime-assertable invariants (@cwgoes )
  • #2801 - Remove AppInit (ready for review)
  • #2752 - Hard coded bonded denom
  • #2746 - Use correct prefix for show-address
  • #2728 - Reorg CLI command structure (docs updated)
  • #2727 - Fix unbonding command flow
  • #2709 - Makefile OS compatibility fix
  • #2682 - Simulator commission rate fix
  • #2565 - Validator delegations querier
  • #2808 - Docs Refactor (R4R)

The following issues really should be investigated prior to Game of Stakes:

  • #2654 - Unbonding fractional shares causes crash (in progress)
  • #2715 - Fix Gaia Lite insecure mode (blocked on tendermint)
  • #2710 - LCD proof verification failure
@fedekunze

This comment has been minimized.

Copy link
Contributor

fedekunze commented Nov 11, 2018

@jackzampolin Can we add #2576 as well (it's R4R)? otherwise we'll have to use hardcoded values for the gov params on Voyager

@jaekwon

This comment has been minimized.

Copy link
Contributor

jaekwon commented Nov 12, 2018

stake bond denom refactor cannot be merged for 9001. Also that PR isn't complete, so, will do for GoS instead.

@bneiluj

This comment has been minimized.

Copy link

bneiluj commented Nov 12, 2018

gaia-9001 is down due to Consensus Failure.

link to bugs:
#2772
#2776 (Attacker can submit TX with negative Fee minting tokens 👏)

@jackzampolin jackzampolin changed the title Game of Stakes / gaia-9000 release checklist Game of Stakes / gaia-9002 release checklist Nov 12, 2018

@mdyring

This comment has been minimized.

Copy link

mdyring commented Nov 13, 2018

Would be great to fix excessive logging of "Send failed" as well: tendermint/tendermint#1817

I'd recommend logging as "debug" level or not at all. Logging "Send failed" with error severity seems wrong, provides little operational information and makes logs fill up quickly.

@alexanderbez

This comment has been minimized.

Copy link
Contributor

alexanderbez commented Nov 13, 2018

@mdyring yes, we've discussed this along with a few other logging tweaks. I wouldn't say it's critical to get in, but certainly if we can!

@alexanderbez

This comment has been minimized.

Copy link
Contributor

alexanderbez commented Nov 16, 2018

@jackzampolin @gamarin2 do we want gas uint (#2839) in for GoS? I believe it's ready.

@jackzampolin

This comment has been minimized.

Copy link
Contributor

jackzampolin commented Nov 29, 2018

v0.27.0 just got cut. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment