New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overflow in gas wanted conversion can cause txs to have negative gas on tm side #3068

Closed

ValarDragon opened this issue Dec 10, 2018 · 0 comments · Fixed by #3070

Assignees

Contributor

ValarDragon commented Dec 10, 2018

https://github.com/cosmos/cosmos-sdk/blob/develop/baseapp/baseapp.go#L535

We need to make that ensure that the tx's gas is not greater than 2**63 -1. See tendermint/tendermint#2989

alexanderbez self-assigned this

alexanderbez mentioned this issue

R4R: Check for gas overflow in tx validation #3070

Merged

5 tasks

cwgoes closed this as completed in #3070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment