You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
By using the Potential Tendermint Power we remove any Int64 overflow issues, not to mention make the variable names in the code reflective of reality (currently these variable names are misleading/incorrect - this is NOT the tendermint power, the tendermint power is equivalent to Potential Tendermint Power)
nice, I like ConsensusPower - and yeah making its own type makes sense I think
rigelrozanski
changed the title
Staking ValidatorPowerRank should use "Potential Tendermint Power"
Staking ValidatorPowerRank should use "Potential Consensus Power"
Apr 2, 2019
Referring to "Potential Tendermint Power" as the tokens reduced by a threshold (as is currently used within the ABCI)
cosmos-sdk/types/staking.go
Line 48 in d00a15b
This issue is followup to this comment in the code which contains incorrect variable names:
cosmos-sdk/x/staking/keeper/key.go
Lines 72 to 79 in 9cf9e6f
Which was referenced recently in #2439
By using the Potential Tendermint Power we remove any Int64 overflow issues, not to mention make the variable names in the code reflective of reality (currently these variable names are misleading/incorrect - this is NOT the tendermint power, the tendermint power is equivalent to Potential Tendermint Power)
CC @alexanderbez @keichiri @cwgoes
The text was updated successfully, but these errors were encountered: