docs: lint ADR-070

[alexanderbez]

Description

• Update filename
• Lint

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Documentation
  • Added a new Architecture Decision Record (ADR 070: Un-Ordered Transaction Inclusion) detailing the proposal for replay-attack protection and handling of un-ordered transactions.
  • Updated the architecture README to include the new ADR.

[coderabbitai]

Walkthrough

Walkthrough

A new architectural decision record (ADR) has been added to the project documentation, proposing a mechanism for including un-ordered transactions in a blockchain system. This ADR outlines a strategy to prevent replay attacks without relying on transaction order or nonces, introduces a boolean field to mark transactions as un-ordered, and describes how these transactions should be handled and stored. It also details the necessary code integration and start-up procedures to support this feature.

Changes

File Path	Change Summary
docs/architecture/README.md	Added a new ADR entry, "ADR 070: Un-Ordered Transaction Inclusion."
docs/architecture/.../adr-070-unordered-account.md	Introduced a proposal for replay-attack protection, a new unordered boolean field in the transaction body, handling and storage of un-ordered transactions, and implementation details for code wiring and start-up procedures.

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 623cdf0 and 6e90754.

Files selected for processing (2)

• docs/architecture/README.md (1 hunks)
• docs/architecture/adr-070-unordered-account.md (3 hunks)

Files skipped from review due to trivial changes (1)

• docs/architecture/README.md

Additional comments: 5

docs/architecture/adr-070-unordered-account.md (5)

• 7-9: The status of the ADR is marked as ACCEPTED. Ensure that this status is correct and reflects the current consensus on the proposal.

• 27-44: The proposal to add a boolean field unordered to the transaction body and the associated rules for handling un-ordered transactions are clearly outlined. Ensure that these changes are consistent with the overall design goals and system requirements.

• 40-44: The implementation details for the dictionary of un-ordered transactions suggest using an in-memory map with specific considerations for memory management, expiration limits, and size constraints. Verify that these considerations are sufficient and that they align with the system's performance and scalability requirements.

• 237-243: The OnNewBlock method of DedupTxHashManager needs to be wired into the BaseApp's ABCI Commit event, and the node must re-fill the transaction hash dictionary on start-up by scanning historical blocks. Confirm that these integration steps are feasible and that they do not introduce significant overhead or complexity to the system.

• 256-256: The negative consequence of start-up overhead to scan historical blocks is noted. Ensure that this overhead is acceptable and that measures are in place to minimize its impact on the system's start-up time.