New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: removed governance slashing #2395

Merged
merged 1 commit into from Sep 25, 2018

Conversation

Projects
None yet
4 participants
@sunnya97
Copy link
Member

sunnya97 commented Sep 25, 2018

closes #2256

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@sunnya97 sunnya97 changed the title removed governance slashing R4R: removed governance slashing Sep 25, 2018

@sunnya97 sunnya97 force-pushed the sunny/remove-gov-slashing branch from 4f379c8 to a0bbcde Sep 25, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 25, 2018

Codecov Report

Merging #2395 into develop will decrease coverage by 0.42%.
The diff coverage is 85.71%.

@@             Coverage Diff             @@
##           develop    #2395      +/-   ##
===========================================
- Coverage    63.54%   63.12%   -0.43%     
===========================================
  Files          120      120              
  Lines         7236     7224      -12     
===========================================
- Hits          4598     4560      -38     
- Misses        2326     2350      +24     
- Partials       312      314       +2
@ValarDragon

This comment has been minimized.

Copy link
Member

ValarDragon commented Sep 25, 2018

Hrmm. An interesting consequence of this is that the the simulator will no longer catch a significant portion of the slashing bugs its been finding, until we fix #2320. This is because they were all being caught on governance slashing, and only execute after a slashing occurred. We'll have to do a bunch more work to now test our staking code, but thats nbd. I'll make a follow-up issue

@alexanderbez
Copy link
Contributor

alexanderbez left a comment

utACK -- thanks!

@cwgoes

cwgoes approved these changes Sep 25, 2018

Copy link
Contributor

cwgoes left a comment

utACK but waiting to merge for the moment (want to wait for simulation updates re @ValarDragon's comment)

@alexanderbez

This comment has been minimized.

Copy link
Contributor

alexanderbez commented Sep 25, 2018

Ref: #2396

@cwgoes cwgoes merged commit 15e848e into develop Sep 25, 2018

11 checks passed

ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: localnet Your tests passed on CircleCI!
Details
ci/circleci: setup_dependencies Your tests passed on CircleCI!
Details
ci/circleci: test_cover Your tests passed on CircleCI!
Details
ci/circleci: test_sim_gaia_fast Your tests passed on CircleCI!
Details
ci/circleci: test_sim_gaia_nondeterminism Your tests passed on CircleCI!
Details
ci/circleci: test_sim_modules Your tests passed on CircleCI!
Details
ci/circleci: upload_coverage Your tests passed on CircleCI!
Details
codecov/patch 85.71% of diff hit (target 63.54%)
Details
codecov/project Absolute coverage decreased by -0.42% but relative coverage increased by +22.17% compared to c31c0d2
Details
@cwgoes

This comment has been minimized.

Copy link
Contributor

cwgoes commented Sep 25, 2018

Ref: #2396

Thanks. Merging now, let's make sure to address #2396 before releasing the next version.

@cwgoes cwgoes deleted the sunny/remove-gov-slashing branch Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment