New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.25.0 (second try) #2603

Merged
merged 981 commits into from Oct 31, 2018

Conversation

Projects
None yet
@cwgoes
Contributor

cwgoes commented Oct 26, 2018

Release 0.25.0

PR to merge back to develop: #2604


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

rigelrozanski and others added some commits Oct 9, 2018

...
R4R: Fix simulation proposer (#2460)
* Correctly set proposer in randomized simulation

* Return nil if no validators are present
Lock binary dependencies to a specific commits / versions
This is basically copying over @anton's great script!

Also had to run `make format` to make this pass `test_lint`.
This PR also makes the make commands for tools further align
with the tendermint implementation.
Alessio/server refactor (#2472)
* Add arg to PrintUnsignedStdTx() to actually operate in offline mode
* WIP simplifying server module
* Expose ExternalIP()
* Move {GenTx,Init}Cmd into gaia's new init package

jaekwon and others added some commits Oct 26, 2018

Merge PR #2599 from cosmos/jae/dist_refactor
* Rename Pool -> DelRewards; PoolCommission -> ValCommision
* FeePool.Pool -> FeePool.ValPool
* WithdrawalHeight->DelPoolWithdrawalHeight
* OnValidatorBeginUnbonding
* Caught the bug's tail
* Update vi.FeePoolWithdrawalHeight upon bonding
* Fix staking slashUnbondingDelegation bug; fixes simulator failure #9
@codecov

This comment has been minimized.

codecov bot commented Oct 26, 2018

Codecov Report

Merging #2603 into master will decrease coverage by 4.93%.
The diff coverage is 36.84%.

@@            Coverage Diff             @@
##           master    #2603      +/-   ##
==========================================
- Coverage   63.76%   58.83%   -4.94%     
==========================================
  Files         113      152      +39     
  Lines        6671     9420    +2749     
==========================================
+ Hits         4254     5542    +1288     
- Misses       2131     3508    +1377     
- Partials      286      370      +84
@cwgoes

This comment has been minimized.

Contributor

cwgoes commented Oct 26, 2018

Just finished stage 6 of the release process - next up: buddy testing & internal testnet.

@cwgoes

This comment has been minimized.

Contributor

cwgoes commented Oct 26, 2018

500-block multi-seed simulation passes.

@alexanderbez

This comment has been minimized.

Contributor

alexanderbez commented Oct 26, 2018

I think we may need to linkify again? I saw one (BFT gov) entry in the log w/o a link.

@cwgoes

This comment has been minimized.

Contributor

cwgoes commented Oct 26, 2018

I think we may need to linkify again? I saw one (BFT gov) entry in the log w/o a link.

The script doesn't change anything (wrong regex?) - fixed the gov entry manually.

edit: Also fixed several other entries manually.

@cwgoes

This comment has been minimized.

Contributor

cwgoes commented Oct 26, 2018

Found a minor doc inconsistency - #2608.

@cwgoes

This comment has been minimized.

Contributor

cwgoes commented Oct 26, 2018

I can query with gaiacli query proposals just fine, but when I query a particular proposal - gaiacli query proposal 1 - I get:

ERROR: {"codespace":5,"code":1,"abci_code":327681,"message":"Error{Unknown proposal with id 0}"}
@cwgoes

This comment has been minimized.

Contributor

cwgoes commented Oct 26, 2018

One oddity: #2610. Probably not critical.

@cwgoes

This comment has been minimized.

Contributor

cwgoes commented Oct 26, 2018

I got everything to work in the client docs except querying proposals.

cwgoes added some commits Oct 26, 2018

@alexanderbez

This comment has been minimized.

Contributor

alexanderbez commented Oct 26, 2018

The docs are correct @cwgoes, you must use --proposal-id.

@cwgoes

This comment has been minimized.

Contributor

cwgoes commented Oct 26, 2018

The docs are correct @cwgoes, you must use --proposal-id.

Oh oops - you're right, thanks - that error message is not helpful though.

@cwgoes

This comment has been minimized.

Contributor

cwgoes commented Oct 26, 2018

@mossid and I both went through the client docs & validator setup docs, all seems in order, I updated the files with changes to CLI syntax where necessary.

@alexanderbez

alexanderbez approved these changes Oct 26, 2018 edited

testedACK 🎉

@cwgoes

This comment has been minimized.

Contributor

cwgoes commented Oct 28, 2018

CC @jaekwon or @ebuchman for merge - we concurred in the Friday standup that 0.25 is ready for release (unless plans have changed since then).

When you merge this, if you could merge #2604 right after so we can keep in sync that would be 💘 .

@jaekwon jaekwon merged commit 7c5c14f into master Oct 31, 2018

10 of 12 checks passed

codecov/patch 36.84% of diff hit (target 63.76%)
Details
codecov/project 58.83% (-4.94%) compared to 50675b8
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: localnet Your tests passed on CircleCI!
Details
ci/circleci: setup_dependencies Your tests passed on CircleCI!
Details
ci/circleci: test_cover Your tests passed on CircleCI!
Details
ci/circleci: test_sim_gaia_fast Your tests passed on CircleCI!
Details
ci/circleci: test_sim_gaia_multi_seed Your tests passed on CircleCI!
Details
ci/circleci: test_sim_gaia_nondeterminism Your tests passed on CircleCI!
Details
ci/circleci: test_sim_modules Your tests passed on CircleCI!
Details
ci/circleci: upload_coverage Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment