R4R: DOCS: fix links and add cli to sidebar #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zramsay
reviewed
Nov 15, 2018
Codecov Report
@@ Coverage Diff @@
## develop #2830 +/- ##
===========================================
+ Coverage 56.73% 56.75% +0.02%
===========================================
Files 131 131
Lines 8554 8554
===========================================
+ Hits 4853 4855 +2
+ Misses 3368 3366 -2
Partials 333 333 |
gamarin2
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
zramsay
approved these changes
Nov 15, 2018
zramsay
reviewed
Nov 15, 2018
| @@ -26,12 +26,13 @@ module.exports = { | |||
| children: [ | |||
| "/gaia/installation", | |||
| "/gaia/join-testnet", | |||
| "/gaia/validators/validator-setup", | |||
There was a problem hiding this comment.
shouldn't the validator info be in together, maybe move networks up?
There was a problem hiding this comment.
I changed it cause the end of join-testnet points to validator-setup, and because the next logical step after running a full node is to upgrade to a validator. I'll move networks down instead
jackzampolin
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2818