Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Add fees and memo to REST, updated CLI to receive coins as fees #3069

Merged
merged 62 commits into from Dec 20, 2018
Merged

R4R: Add fees and memo to REST, updated CLI to receive coins as fees #3069

merged 62 commits into from Dec 20, 2018

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Dec 10, 2018 •
edited

closes #3067
closes #3020

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze added the wip label Dec 10, 2018
@fedekunze fedekunze self-assigned this Dec 10, 2018
fedekunze
fedekunze commented Dec 10, 2018
View reviewed changes
client/utils/rest.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 11, 2018 •
edited

Codecov Report

Merging #3069 into develop will decrease coverage by 0.17%.
The diff coverage is 61.38%.

@@            Coverage Diff             @@
##           develop   #3069      +/-   ##
==========================================
- Coverage    54.88%   54.7%   -0.18%     
==========================================
  Files          132     132              
  Lines         9446    9420      -26     
==========================================
- Hits          5184    5153      -31     
- Misses        3943    3949       +6     
+ Partials       319     318       -1

Merge branch 'jack/dry-rest-tests' of https://github.com/cosmos/cosmo…
9c82e31 
…s-sdk into fedekunze/3067-fee-rest-txs

Merge Jack's LCD test refactor
@fedekunze fedekunze mentioned this pull request Dec 18, 2018
Closed
jackzampolin
jackzampolin reviewed Dec 18, 2018
View reviewed changes
client/utils/rest.go Outdated Show resolved Hide resolved
jackzampolin
jackzampolin approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, but this looks good!

alexanderbez
alexanderbez previously requested changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very close, just a few minor comments.

client/utils/rest.go Outdated Show resolved Hide resolved
client/utils/rest.go Outdated Show resolved Hide resolved
x/auth/client/txbuilder/txbuilder.go Outdated Show resolved Hide resolved
alessio
alessio previously requested changes Dec 19, 2018
View reviewed changes
client/utils/rest.go Outdated Show resolved Hide resolved
@fedekunze fedekunze dismissed stale reviews from alexanderbez and alessio December 19, 2018 13:51

addressed comments

alexanderbez
alexanderbez previously requested changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @fedekunze -- just two minor remarks worth addressing.

PENDING.md
@@ -3,11 +3,13 @@
BREAKING CHANGES

* Gaia REST API (`gaiacli advanced rest-server`)
* [gaia-lite] [\#2182] Renamed and merged all redelegations endpoints into `/stake/redelegations`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some of these additions don't belong here...possible from a bad merge/rebase.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it was from sunny's PR which had PENDING entries from other releases. Also that PR had breaking changes which weren't added (that's why I changed them here).

Already talked with @jackzampolin and he said it was fine to do this changes on the PENDING here

x/auth/client/rest/sign.go Outdated Show resolved Hide resolved
@alessio alessio added the T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). label Dec 20, 2018
@alessio
Copy link
Contributor

alessio commented Dec 20, 2018

Breaking change added due to flag --fee changing to --fees

alexanderbez
alexanderbez approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed this a handful of times, but not sure if I missed anything, so I think @alessio could spare a review here too. Overall, LGTM 👍

@jackzampolin jackzampolin merged commit f02f7aa into develop Dec 20, 2018
@jackzampolin jackzampolin deleted the fedekunze/3067-fee-rest-txs branch December 20, 2018 00:26
@fedekunze fedekunze mentioned this pull request Dec 21, 2018
Closed
joe-bowman pushed a commit to joe-bowman/cosmos-sdk that referenced this pull request Jan 7, 2019
@fedekunze
Add fees and memo to REST, updated CLI to receive coins as fees (cosm…
248b9f6 
…os#3069)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faboweb faboweb faboweb left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

@jackzampolin jackzampolin jackzampolin approved these changes

@alessio alessio alessio left review comments

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees

@fedekunze fedekunze

Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define fee on REST txs Delegations REST endpoint require name and password when generate_only is passed
5 participants
@fedekunze @jackzampolin @alexanderbez @alessio @faboweb