Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ICS Implementation #4427

Closed
wants to merge 18 commits into from

Conversation

Projects
None yet
2 participants
@mossid
Copy link
Contributor

commented May 28, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer

This PR is for tracking and will be split into multiple parts for review


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
db := dbm.NewMemDB()
cms := store.NewCommitMultiStore(db)
cms.MountStoreWithDB(key, sdk.StoreTypeIAVL, db)
cms.LoadLatestVersion()

This comment has been minimized.

Copy link
@golangcibot

golangcibot May 28, 2019

Error return value of cms.LoadLatestVersion is not checked (from errcheck)

return err
}

if obj.remote.nexttimeout.Get(ctx) != uint64(timeoutHeight) {

This comment has been minimized.

Copy link
@golangcibot

golangcibot Jun 7, 2019

unnecessary conversion (from unconvert)

return errors.New("unexpected counterparty client value")
}

obj.nexttimeout.Set(ctx, uint64(nextTimeoutHeight))

This comment has been minimized.

Copy link
@golangcibot

golangcibot Jun 7, 2019

unnecessary conversion (from unconvert)

return err
}

if obj.remote.nexttimeout.Get(ctx) != uint64(timeoutHeight) {

This comment has been minimized.

Copy link
@golangcibot

golangcibot Jun 7, 2019

unnecessary conversion (from unconvert)

// assert(get("connections/{identifier}") === null) and
// set("connections{identifier}", connection)

obj.nexttimeout.Set(ctx, uint64(nextTimeoutHeight))

This comment has been minimized.

Copy link
@golangcibot

golangcibot Jun 7, 2019

unnecessary conversion (from unconvert)

return err
}

if obj.remote.nexttimeout.Get(ctx) != uint64(timeoutHeight) {

This comment has been minimized.

Copy link
@golangcibot

golangcibot Jun 7, 2019

unnecessary conversion (from unconvert)

// assert(get("connections/{desiredIdentifier}") === null) and
// set("connections{identifier}", connection)

obj.nexttimeout.Set(ctx, uint64(nextTimeoutHeight))

This comment has been minimized.

Copy link
@golangcibot

golangcibot Jun 7, 2019

unnecessary conversion (from unconvert)

return err
}

if !obj.remote.nexttimeout.Is(ctx, uint64(timeoutHeight)) {

This comment has been minimized.

Copy link
@golangcibot

golangcibot Jun 7, 2019

unnecessary conversion (from unconvert)

return err
}

if !obj.remote.nexttimeout.Is(ctx, uint64(timeoutHeight)) {

This comment has been minimized.

Copy link
@golangcibot

golangcibot Jun 7, 2019

unnecessary conversion (from unconvert)

return err
}

if !obj.remote.nexttimeout.Is(ctx, uint64(timeoutHeight)) {

This comment has been minimized.

Copy link
@golangcibot

golangcibot Jun 7, 2019

unnecessary conversion (from unconvert)

@mossid mossid closed this Jun 7, 2019

@mossid mossid deleted the joon/ics-implementation branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.