Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Validators v0.36 #4770

Merged
merged 5 commits into from Jul 23, 2019

Conversation

@alexanderbez
Copy link
Contributor

commented Jul 23, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
@alexanderbez alexanderbez added the WIP label Jul 23, 2019
@codecov

This comment has been minimized.

Copy link

commented Jul 23, 2019

Codecov Report

Merging #4770 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4770   +/-   ##
=======================================
  Coverage   53.88%   53.88%           
=======================================
  Files         270      270           
  Lines       17230    17230           
=======================================
  Hits         9285     9285           
  Misses       7261     7261           
  Partials      684      684
@alexanderbez alexanderbez marked this pull request as ready for review Jul 23, 2019
@alexanderbez alexanderbez added R4R and removed WIP labels Jul 23, 2019
Rate sdk.Dec `json:"rate"`
MaxRate sdk.Dec `json:"max_rate"`
MaxChangeRate sdk.Dec `json:"max_change_rate"`
Rate sdk.Dec `json:"rate"`

This comment has been minimized.

Copy link
@jackzampolin

jackzampolin Jul 23, 2019

Contributor

This is what the struct actually looks like 👌

Copy link
Contributor

left a comment

ACK cause I know @alexanderbez tested this on mainnet w/ an export.

Copy link
Contributor

left a comment

ack

@alexanderbez alexanderbez merged commit c71eaf7 into master Jul 23, 2019
12 checks passed
12 checks passed
GolangCI No issues found!
Details
ci/circleci: check_statik Your tests passed on CircleCI!
Details
ci/circleci: setup_dependencies Your tests passed on CircleCI!
Details
ci/circleci: test_cover Your tests passed on CircleCI!
Details
ci/circleci: test_sim_app_fast Your tests passed on CircleCI!
Details
ci/circleci: test_sim_app_import_export Your tests passed on CircleCI!
Details
ci/circleci: test_sim_app_multi_seed Your tests passed on CircleCI!
Details
ci/circleci: test_sim_app_nondeterminism Your tests passed on CircleCI!
Details
ci/circleci: test_sim_app_simulation_after_import Your tests passed on CircleCI!
Details
ci/circleci: upload_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 309dacc...054e49e
Details
codecov/project 53.88% remains the same compared to 309dacc
Details
@alexanderbez alexanderbez deleted the bez/0.36-validator-commission-migration branch Jul 23, 2019
alexanderbez added a commit that referenced this pull request Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.