Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.36.0-rc5 馃崚 Picks #4874

Merged
merged 11 commits into from Aug 9, 2019

Conversation

@alexanderbez
Copy link
Contributor

commented Aug 8, 2019

Final RC before v0.36.0 release. The changes here are not mandatory for being tested in the latest testnet but are necessary for the release. We can safely cut a release here regardless.


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
gzhao408 and others added 10 commits Aug 7, 2019

@alexanderbez alexanderbez merged commit 5742d13 into rc5/v0.36.0 Aug 9, 2019

9 checks passed

GolangCI No issues found!
Details
ci/circleci: check_statik Your tests passed on CircleCI!
Details
ci/circleci: setup_dependencies Your tests passed on CircleCI!
Details
ci/circleci: test_cover Your tests passed on CircleCI!
Details
ci/circleci: test_sim_after_import Your tests passed on CircleCI!
Details
ci/circleci: test_sim_import_export Your tests passed on CircleCI!
Details
ci/circleci: test_sim_multi_seed_short Your tests passed on CircleCI!
Details
ci/circleci: test_sim_nondeterminism Your tests passed on CircleCI!
Details
ci/circleci: upload_coverage Your tests passed on CircleCI!
Details

@alexanderbez alexanderbez deleted the bez/v0.36.0-rc5-cherry-picks branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can鈥檛 perform that action at this time.