Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADR-012] - State Accessors #4998

Open
wants to merge 4 commits into
base: master
from

Conversation

@mossid
Copy link
Contributor

commented Sep 4, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
@codecov

This comment has been minimized.

Copy link

commented Sep 4, 2019

Codecov Report

Merging #4998 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4998      +/-   ##
==========================================
- Coverage   55.56%   55.55%   -0.01%     
==========================================
  Files         287      284       -3     
  Lines       17514    17460      -54     
==========================================
- Hits         9731     9700      -31     
+ Misses       7083     7065      -18     
+ Partials      700      695       -5
@mossid mossid referenced this pull request Sep 5, 2019

@marbar3778 marbar3778 changed the title ADR XXX: State Accessors [ADR-012] State Accessors Sep 7, 2019

@marbar3778 marbar3778 changed the title [ADR-012] State Accessors [ADR-012] - State Accessors Sep 7, 2019

mossid and others added 3 commits Sep 10, 2019
Update docs/architecture/adr-xxx-state-accessors.md
Co-Authored-By: Marko <marbar3778@yahoo.com>

@mossid mossid marked this pull request as ready for review Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.