Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for halt-time #5005

Merged
merged 12 commits into from Sep 9, 2019

Conversation

@alexanderbez
Copy link
Contributor

commented Sep 5, 2019

closes: #4979


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added the WIP label Sep 5, 2019

@codecov

This comment has been minimized.

Copy link

commented Sep 5, 2019

Codecov Report

Merging #5005 into master will decrease coverage by 0.06%.
The diff coverage is 13.79%.

@@            Coverage Diff             @@
##           master    #5005      +/-   ##
==========================================
- Coverage   55.56%   55.49%   -0.07%     
==========================================
  Files         287      287              
  Lines       17521    17540      +19     
==========================================
- Hits         9735     9734       -1     
- Misses       7085     7105      +20     
  Partials      701      701
alexanderbez added 3 commits Sep 5, 2019

@alexanderbez alexanderbez added R4R and removed WIP labels Sep 6, 2019

@alexanderbez alexanderbez marked this pull request as ready for review Sep 6, 2019

@alexanderbez alexanderbez requested a review from zmanian Sep 6, 2019

baseapp/abci.go Show resolved Hide resolved
@fedekunze
Copy link
Contributor

left a comment

utACK. 1 minor nit not blocking

baseapp/abci.go Outdated Show resolved Hide resolved
baseapp/abci.go Outdated Show resolved Hide resolved
baseapp/abci.go Show resolved Hide resolved
@alessio
alessio approved these changes Sep 6, 2019
@alexanderbez

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

@tnachen this is a great example of a non-breaking PR that we should get into the next point release (v0.37.1, v0.34.8, and v0.35.0)

alexanderbez added 2 commits Sep 6, 2019
@alessio

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

I sketched an alternative solution based on goroutine cancellation, which should be a bit safer and cleaner as it does not rely on system-dependant signal implementations: #5010. Downside is that it would introduce a breaking change.

It is a draft and is not meant to replace this PR straightway. I think this PR works, it's not breaking and we should get on with it first, then perhaps work on #5010. Feedback is welcome

baseapp/abci.go Show resolved Hide resolved

@alexanderbez alexanderbez merged commit c8d84b4 into master Sep 9, 2019

11 of 12 checks passed

codecov/patch 13.79% of diff hit (target 55.56%)
Details
GolangCI No issues found!
Details
ci/circleci: build_docs-1 Your tests passed on CircleCI!
Details
ci/circleci: check_statik Your tests passed on CircleCI!
Details
ci/circleci: setup_dependencies Your tests passed on CircleCI!
Details
ci/circleci: test_cover Your tests passed on CircleCI!
Details
ci/circleci: test_sim_after_import Your tests passed on CircleCI!
Details
ci/circleci: test_sim_import_export Your tests passed on CircleCI!
Details
ci/circleci: test_sim_multi_seed_short Your tests passed on CircleCI!
Details
ci/circleci: test_sim_nondeterminism Your tests passed on CircleCI!
Details
ci/circleci: upload_coverage Your tests passed on CircleCI!
Details
codecov/project 55.49% (-0.07%) compared to 2c4faf9
Details

@alexanderbez alexanderbez deleted the bez/4979/halt-time-config branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.