Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: NFT find is broken #5035

Open
wants to merge 10 commits into
base: master
from

Conversation

@okwme
Copy link

commented Sep 11, 2019

In order to fix Issue #5034. Added tests to show find is broken.

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
@fedekunze

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

sadly we can't merge something that breaks the CI, can you fix find too, please?

@fedekunze fedekunze added the x/nft label Sep 11, 2019

@okwme okwme changed the title NFT find is broken WIP: NFT find is broken Sep 11, 2019

@fedekunze fedekunze added the WIP label Sep 11, 2019

@okwme

This comment has been minimized.

Copy link
Author

commented Sep 11, 2019

sorry @fedekunze meant for this to be WIP. Sounds like DGaming might be able to help out here

x/nft/internal/types/utils.go Outdated Show resolved Hide resolved
okwme added 3 commits Sep 18, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 18, 2019

Codecov Report

Merging #5035 into master will decrease coverage by 0.05%.
The diff coverage is 80.28%.

@@            Coverage Diff             @@
##           master    #5035      +/-   ##
==========================================
- Coverage   55.03%   54.97%   -0.06%     
==========================================
  Files         291      292       +1     
  Lines       17839    17842       +3     
==========================================
- Hits         9818     9809       -9     
- Misses       7314     7326      +12     
  Partials      707      707
x/nft/internal/types/owners.go Outdated Show resolved Hide resolved
x/nft/internal/types/owners.go Outdated Show resolved Hide resolved
x/nft/internal/types/owners.go Outdated Show resolved Hide resolved
x/nft/internal/types/owners.go Outdated Show resolved Hide resolved
okwme added 4 commits Sep 18, 2019

@okwme okwme changed the title WIP: NFT find is broken R4R: NFT find is broken Sep 18, 2019

@okwme okwme added bug R4R and removed WIP labels Sep 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.