Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes migrate bug #5095 #5099

Merged
merged 3 commits into from Sep 25, 2019

Conversation

@kwunyeung
Copy link
Contributor

commented Sep 24, 2019

closes: #5096

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
@kwunyeung kwunyeung referenced this pull request Sep 24, 2019
0 of 5 tasks complete
Copy link
Contributor

left a comment

LGTM, thanks @kwunyeung. Can you please add a quick changelog entry under Bug Fixes?

@alexanderbez alexanderbez added the R4R label Sep 24, 2019
@@ -41,6 +41,20 @@ type (
MinSelfDelegation sdk.Int `json:"min_self_delegation" yaml:"min_self_delegation"`
}

bechValidator struct {

This comment has been minimized.

Copy link
@alexanderbez

alexanderbez Sep 24, 2019

Contributor

@kwunyeung can we also do the same change for 0.37 in staking?

This comment has been minimized.

Copy link
@kwunyeung

kwunyeung Sep 25, 2019

Author Contributor

@alexanderbez updated for 0.37 as well.

@codecov

This comment has been minimized.

Copy link

commented Sep 25, 2019

Codecov Report

Merging #5099 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #5099      +/-   ##
=========================================
+ Coverage   54.79%   54.8%   +0.01%     
=========================================
  Files         294     294              
  Lines       18222   18222              
=========================================
+ Hits         9984    9986       +2     
+ Misses       7492    7490       -2     
  Partials      746     746
Copy link
Contributor

left a comment

ACK ❤️

@alexanderbez alexanderbez merged commit 906dcdb into cosmos:master Sep 25, 2019
9 of 10 checks passed
9 of 10 checks passed
ci/circleci: build-docs-1 Your tests failed on CircleCI
Details
GolangCI No issues found!
Details
ci/circleci: setup-dependencies Your tests passed on CircleCI!
Details
ci/circleci: test-cover Your tests passed on CircleCI!
Details
ci/circleci: test-sim-after-import Your tests passed on CircleCI!
Details
ci/circleci: test-sim-import-export Your tests passed on CircleCI!
Details
ci/circleci: test-sim-multi-seed-short Your tests passed on CircleCI!
Details
ci/circleci: test-sim-nondeterminism Your tests passed on CircleCI!
Details
ci/circleci: update-swagger-docs Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
alexanderbez added a commit that referenced this pull request Oct 3, 2019
@alexanderbez alexanderbez referenced this pull request Oct 3, 2019
2 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.