From ca91696e452aeca051988b83c2caf78b06b2cb84 Mon Sep 17 00:00:00 2001 From: Alessio Treglia Date: Wed, 12 Aug 2020 10:02:11 +0100 Subject: [PATCH 1/8] replace testutil.NewTestCaseDir() with Go1.15's T.TempDir() --- README.md | 2 +- client/keys/add_ledger_test.go | 10 +-- client/keys/add_test.go | 7 +- client/keys/delete_test.go | 4 +- client/keys/export_test.go | 3 +- client/keys/import_test.go | 5 +- client/keys/list_test.go | 7 +- client/keys/migrate_test.go | 6 +- client/keys/show_test.go | 4 +- client/tx/tx_test.go | 6 +- crypto/keyring/keyring_ledger_test.go | 8 +- crypto/keyring/keyring_test.go | 114 ++++++-------------------- crypto/keyring/legacy_test.go | 8 +- go.mod | 2 +- go.sum | 2 - server/constructors_test.go | 11 +-- server/export_test.go | 4 +- server/init_test.go | 9 +- testutil/ioutil.go | 9 -- testutil/ioutil_test.go | 17 ---- x/auth/client/cli/cli_test.go | 4 +- x/genutil/client/cli/gentx_test.go | 5 +- x/genutil/client/cli/init_test.go | 28 ++----- x/genutil/client/cli/migrate_test.go | 3 +- x/genutil/utils_test.go | 7 +- x/upgrade/types/storeloader_test.go | 7 +- 26 files changed, 72 insertions(+), 220 deletions(-) diff --git a/README.md b/README.md index 6707950f07ef..38763419615b 100644 --- a/README.md +++ b/README.md @@ -49,7 +49,7 @@ It is being used to build [`Gaia`](https://github.com/cosmos/gaia), the first im **WARNING**: The SDK has mostly stabilized, but we are still making some breaking changes. -**Note**: Requires [Go 1.14+](https://golang.org/dl/) +**Note**: Requires [Go 1.15+](https://golang.org/dl/) ## Quick Start diff --git a/client/keys/add_ledger_test.go b/client/keys/add_ledger_test.go index 3f4cdd53fc5d..0462178fc16c 100644 --- a/client/keys/add_ledger_test.go +++ b/client/keys/add_ledger_test.go @@ -37,9 +37,7 @@ func Test_runAddCmdLedgerWithCustomCoinType(t *testing.T) { cmd.Flags().AddFlagSet(Commands("home").PersistentFlags()) // Prepare a keybase - kbHome, kbCleanUp := testutil.NewTestCaseDir(t) - require.NotNil(t, kbHome) - t.Cleanup(kbCleanUp) + kbHome := t.TempDir() cmd.SetArgs([]string{ "keyname1", @@ -86,11 +84,7 @@ func Test_runAddCmdLedger(t *testing.T) { cmd := AddKeyCommand() cmd.Flags().AddFlagSet(Commands("home").PersistentFlags()) mockIn := testutil.ApplyMockIODiscardOutErr(cmd) - - // Prepare a keybase - kbHome, kbCleanUp := testutil.NewTestCaseDir(t) - require.NotNil(t, kbHome) - t.Cleanup(kbCleanUp) + kbHome := t.TempDir() cmd.SetArgs([]string{ "keyname1", diff --git a/client/keys/add_test.go b/client/keys/add_test.go index 2222023f257e..99c63dbbf1cd 100644 --- a/client/keys/add_test.go +++ b/client/keys/add_test.go @@ -20,12 +20,9 @@ func Test_runAddCmdBasic(t *testing.T) { cmd.Flags().AddFlagSet(Commands("home").PersistentFlags()) mockIn := testutil.ApplyMockIODiscardOutErr(cmd) - - kbHome, kbCleanUp := testutil.NewTestCaseDir(t) - require.NotNil(t, kbHome) - t.Cleanup(kbCleanUp) - + kbHome := t.TempDir() kb, err := keyring.New(sdk.KeyringServiceName(), keyring.BackendTest, kbHome, mockIn) + require.NoError(t, err) t.Cleanup(func() { _ = kb.Delete("keyname1") diff --git a/client/keys/delete_test.go b/client/keys/delete_test.go index fc70c7e85286..da863ef1253a 100644 --- a/client/keys/delete_test.go +++ b/client/keys/delete_test.go @@ -15,9 +15,7 @@ import ( func Test_runDeleteCmd(t *testing.T) { // Now add a temporary keybase - kbHome, cleanUp := testutil.NewTestCaseDir(t) - t.Cleanup(cleanUp) - + kbHome := t.TempDir() cmd := DeleteKeyCommand() cmd.Flags().AddFlagSet(Commands(kbHome).PersistentFlags()) mockIn := testutil.ApplyMockIODiscardOutErr(cmd) diff --git a/client/keys/export_test.go b/client/keys/export_test.go index 39ed112079e3..7f48795c51cb 100644 --- a/client/keys/export_test.go +++ b/client/keys/export_test.go @@ -20,8 +20,7 @@ func Test_runExportCmd(t *testing.T) { mockIn := testutil.ApplyMockIODiscardOutErr(cmd) // Now add a temporary keybase - kbHome, cleanUp := testutil.NewTestCaseDir(t) - t.Cleanup(cleanUp) + kbHome := t.TempDir() // create a key kb, err := keyring.New(sdk.KeyringServiceName(), keyring.BackendTest, kbHome, mockIn) diff --git a/client/keys/import_test.go b/client/keys/import_test.go index 34a90ffcd3ce..d6e98a74ec22 100644 --- a/client/keys/import_test.go +++ b/client/keys/import_test.go @@ -20,10 +20,9 @@ func Test_runImportCmd(t *testing.T) { mockIn := testutil.ApplyMockIODiscardOutErr(cmd) // Now add a temporary keybase - kbHome, cleanUp := testutil.NewTestCaseDir(t) - t.Cleanup(cleanUp) - + kbHome := t.TempDir() kb, err := keyring.New(sdk.KeyringServiceName(), keyring.BackendTest, kbHome, mockIn) + require.NoError(t, err) t.Cleanup(func() { kb.Delete("keyname1") // nolint:errcheck diff --git a/client/keys/list_test.go b/client/keys/list_test.go index 9c9f93716daf..78c4e94857bb 100644 --- a/client/keys/list_test.go +++ b/client/keys/list_test.go @@ -18,11 +18,8 @@ func Test_runListCmd(t *testing.T) { cmd := ListKeysCmd() cmd.Flags().AddFlagSet(Commands("home").PersistentFlags()) - kbHome1, cleanUp1 := testutil.NewTestCaseDir(t) - t.Cleanup(cleanUp1) - - kbHome2, cleanUp2 := testutil.NewTestCaseDir(t) - t.Cleanup(cleanUp2) + kbHome1 := t.TempDir() + kbHome2 := t.TempDir() mockIn := testutil.ApplyMockIODiscardOutErr(cmd) kb, err := keyring.New(sdk.KeyringServiceName(), keyring.BackendTest, kbHome2, mockIn) diff --git a/client/keys/migrate_test.go b/client/keys/migrate_test.go index c03dca024b22..2918d1e93468 100644 --- a/client/keys/migrate_test.go +++ b/client/keys/migrate_test.go @@ -18,11 +18,9 @@ func Test_runMigrateCmd(t *testing.T) { _ = testutil.ApplyMockIODiscardOutErr(cmd) cmd.Flags().AddFlagSet(Commands("home").PersistentFlags()) - kbHome, kbCleanUp := testutil.NewTestCaseDir(t) - copy.Copy("testdata", kbHome) - assert.NotNil(t, kbHome) - t.Cleanup(kbCleanUp) + kbHome := t.TempDir() + copy.Copy("testdata", kbHome) cmd.SetArgs([]string{ "keyname1", fmt.Sprintf("--%s=%s", flags.FlagHome, kbHome), diff --git a/client/keys/show_test.go b/client/keys/show_test.go index 6e367b3ad911..3b696631f282 100644 --- a/client/keys/show_test.go +++ b/client/keys/show_test.go @@ -46,9 +46,7 @@ func Test_runShowCmd(t *testing.T) { cmd.SetArgs([]string{"invalid1", "invalid2"}) require.EqualError(t, cmd.Execute(), "invalid1 is not a valid name or address: decoding bech32 failed: invalid index of 1") - kbHome, cleanUp := testutil.NewTestCaseDir(t) - t.Cleanup(cleanUp) - + kbHome := t.TempDir() fakeKeyName1 := "runShowCmd_Key1" fakeKeyName2 := "runShowCmd_Key2" diff --git a/client/tx/tx_test.go b/client/tx/tx_test.go index fb3f36c578a4..fddc8c1e44ab 100644 --- a/client/tx/tx_test.go +++ b/client/tx/tx_test.go @@ -4,7 +4,6 @@ import ( "errors" "testing" - "github.com/cosmos/cosmos-sdk/testutil" "github.com/cosmos/cosmos-sdk/x/auth/signing" "github.com/stretchr/testify/require" @@ -115,10 +114,9 @@ func TestBuildUnsignedTx(t *testing.T) { } func TestSign(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) - + dir := t.TempDir() path := hd.CreateHDPath(118, 0, 0).String() + kr, err := keyring.New(t.Name(), "test", dir, nil) require.NoError(t, err) diff --git a/crypto/keyring/keyring_ledger_test.go b/crypto/keyring/keyring_ledger_test.go index e94ba395aaaa..43e5f162baa1 100644 --- a/crypto/keyring/keyring_ledger_test.go +++ b/crypto/keyring/keyring_ledger_test.go @@ -9,7 +9,6 @@ import ( "github.com/stretchr/testify/require" "github.com/cosmos/cosmos-sdk/crypto/hd" - "github.com/cosmos/cosmos-sdk/testutil" "github.com/cosmos/cosmos-sdk/types" sdk "github.com/cosmos/cosmos-sdk/types" ) @@ -52,8 +51,8 @@ func TestInMemoryCreateLedger(t *testing.T) { // TestSignVerify does some detailed checks on how we sign and validate // signatures func TestSignVerifyKeyRingWithLedger(t *testing.T) { - dir, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) + dir := t.TempDir() + kb, err := New("keybasename", "test", dir, nil) require.NoError(t, err) @@ -89,8 +88,7 @@ func TestSignVerifyKeyRingWithLedger(t *testing.T) { } func TestAltKeyring_SaveLedgerKey(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) + dir := t.TempDir() keyring, err := New(t.Name(), BackendTest, dir, nil) require.NoError(t, err) diff --git a/crypto/keyring/keyring_test.go b/crypto/keyring/keyring_test.go index 4b63b1efd3f7..633dfbba65e6 100644 --- a/crypto/keyring/keyring_test.go +++ b/crypto/keyring/keyring_test.go @@ -15,7 +15,6 @@ import ( "github.com/cosmos/cosmos-sdk/crypto" "github.com/cosmos/cosmos-sdk/crypto/hd" "github.com/cosmos/cosmos-sdk/crypto/types/multisig" - "github.com/cosmos/cosmos-sdk/testutil" sdk "github.com/cosmos/cosmos-sdk/types" ) @@ -30,9 +29,9 @@ func init() { } func TestNewKeyring(t *testing.T) { - dir, cleanup := testutil.NewTestCaseDir(t) + dir := t.TempDir() mockIn := strings.NewReader("") - t.Cleanup(cleanup) + kr, err := New("cosmos", BackendFile, dir, mockIn) require.NoError(t, err) @@ -48,9 +47,7 @@ func TestNewKeyring(t *testing.T) { } func TestKeyManagementKeyRing(t *testing.T) { - dir, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) - kb, err := New("keybasename", "test", dir, nil) + kb, err := New("keybasename", "test", t.TempDir(), nil) require.NoError(t, err) algo := hd.Secp256k1 @@ -130,8 +127,7 @@ func TestKeyManagementKeyRing(t *testing.T) { } func TestSignVerifyKeyRing(t *testing.T) { - dir, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) + dir := t.TempDir() kb, err := New("keybasename", "test", dir, nil) require.NoError(t, err) @@ -209,9 +205,7 @@ func TestSignVerifyKeyRing(t *testing.T) { } func TestExportImportKeyRing(t *testing.T) { - dir, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) - kb, err := New("keybasename", "test", dir, nil) + kb, err := New("keybasename", "test", t.TempDir(), nil) require.NoError(t, err) info, _, err := kb.NewMnemonic("john", English, sdk.FullFundraiserPath, hd.Secp256k1) @@ -243,9 +237,7 @@ func TestExportImportKeyRing(t *testing.T) { } func TestExportImportPubKeyKeyRing(t *testing.T) { - dir, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) - kb, err := New("keybasename", "test", dir, nil) + kb, err := New("keybasename", "test", t.TempDir(), nil) require.NoError(t, err) algo := hd.Secp256k1 @@ -283,8 +275,7 @@ func TestExportImportPubKeyKeyRing(t *testing.T) { } func TestAdvancedKeyManagementKeyRing(t *testing.T) { - dir, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) + dir := t.TempDir() kb, err := New("keybasename", "test", dir, nil) require.NoError(t, err) @@ -319,8 +310,8 @@ func TestAdvancedKeyManagementKeyRing(t *testing.T) { } func TestSeedPhraseKeyRing(t *testing.T) { - dir, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) + dir := t.TempDir() + kb, err := New("keybasename", "test", dir, nil) require.NoError(t, err) @@ -350,9 +341,7 @@ func TestSeedPhraseKeyRing(t *testing.T) { } func TestKeyringKeybaseExportImportPrivKey(t *testing.T) { - dir, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) - kb, err := New("keybasename", "test", dir, nil) + kb, err := New("keybasename", "test", t.TempDir(), nil) require.NoError(t, err) _, _, err = kb.NewMnemonic("john", English, sdk.FullFundraiserPath, hd.Secp256k1) @@ -729,10 +718,7 @@ func TestInMemorySeedPhrase(t *testing.T) { } func TestKeyChain_ShouldFailWhenAddingSameGeneratedAccount(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) - - kr, err := New(t.Name(), BackendTest, dir, nil) + kr, err := New(t.Name(), BackendTest, t.TempDir(), nil) require.NoError(t, err) // Given we create a mnemonic @@ -801,8 +787,7 @@ func ExampleNew() { } func TestAltKeyring_List(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) + dir := t.TempDir() keyring, err := New(t.Name(), BackendTest, dir, nil) require.NoError(t, err) @@ -835,10 +820,7 @@ func TestAltKeyring_List(t *testing.T) { } func TestAltKeyring_NewAccount(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) - - keyring, err := New(t.Name(), BackendTest, dir, nil) + keyring, err := New(t.Name(), BackendTest, t.TempDir(), nil) require.NoError(t, err) entropy, err := bip39.NewEntropy(defaultEntropySize) @@ -864,10 +846,7 @@ func TestAltKeyring_NewAccount(t *testing.T) { } func TestAltKeyring_Get(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) - - keyring, err := New(t.Name(), BackendTest, dir, nil) + keyring, err := New(t.Name(), BackendTest, t.TempDir(), nil) require.NoError(t, err) uid := someKey @@ -880,10 +859,7 @@ func TestAltKeyring_Get(t *testing.T) { } func TestAltKeyring_KeyByAddress(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) - - keyring, err := New(t.Name(), BackendTest, dir, nil) + keyring, err := New(t.Name(), BackendTest, t.TempDir(), nil) require.NoError(t, err) uid := someKey @@ -896,10 +872,7 @@ func TestAltKeyring_KeyByAddress(t *testing.T) { } func TestAltKeyring_Delete(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) - - keyring, err := New(t.Name(), BackendTest, dir, nil) + keyring, err := New(t.Name(), BackendTest, t.TempDir(), nil) require.NoError(t, err) uid := someKey @@ -919,10 +892,7 @@ func TestAltKeyring_Delete(t *testing.T) { } func TestAltKeyring_DeleteByAddress(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) - - keyring, err := New(t.Name(), BackendTest, dir, nil) + keyring, err := New(t.Name(), BackendTest, t.TempDir(), nil) require.NoError(t, err) uid := someKey @@ -942,10 +912,7 @@ func TestAltKeyring_DeleteByAddress(t *testing.T) { } func TestAltKeyring_SavePubKey(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) - - keyring, err := New(t.Name(), BackendTest, dir, nil) + keyring, err := New(t.Name(), BackendTest, t.TempDir(), nil) require.NoError(t, err) list, err := keyring.List() @@ -968,10 +935,7 @@ func TestAltKeyring_SavePubKey(t *testing.T) { } func TestAltKeyring_SaveMultisig(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) - - keyring, err := New(t.Name(), BackendTest, dir, nil) + keyring, err := New(t.Name(), BackendTest, t.TempDir(), nil) require.NoError(t, err) mnemonic1, _, err := keyring.NewMnemonic("key1", English, sdk.FullFundraiserPath, hd.Secp256k1) @@ -993,10 +957,7 @@ func TestAltKeyring_SaveMultisig(t *testing.T) { } func TestAltKeyring_Sign(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) - - keyring, err := New(t.Name(), BackendTest, dir, nil) + keyring, err := New(t.Name(), BackendTest, t.TempDir(), nil) require.NoError(t, err) uid := "jack" @@ -1012,10 +973,7 @@ func TestAltKeyring_Sign(t *testing.T) { } func TestAltKeyring_SignByAddress(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) - - keyring, err := New(t.Name(), BackendTest, dir, nil) + keyring, err := New(t.Name(), BackendTest, t.TempDir(), nil) require.NoError(t, err) uid := "jack" @@ -1031,10 +989,7 @@ func TestAltKeyring_SignByAddress(t *testing.T) { } func TestAltKeyring_ImportExportPrivKey(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) - - keyring, err := New(t.Name(), BackendTest, dir, nil) + keyring, err := New(t.Name(), BackendTest, t.TempDir(), nil) require.NoError(t, err) uid := theID @@ -1060,10 +1015,7 @@ func TestAltKeyring_ImportExportPrivKey(t *testing.T) { } func TestAltKeyring_ImportExportPrivKey_ByAddress(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) - - keyring, err := New(t.Name(), BackendTest, dir, nil) + keyring, err := New(t.Name(), BackendTest, t.TempDir(), nil) require.NoError(t, err) uid := theID @@ -1090,10 +1042,7 @@ func TestAltKeyring_ImportExportPrivKey_ByAddress(t *testing.T) { } func TestAltKeyring_ImportExportPubKey(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) - - keyring, err := New(t.Name(), BackendTest, dir, nil) + keyring, err := New(t.Name(), BackendTest, t.TempDir(), nil) require.NoError(t, err) uid := theID @@ -1115,10 +1064,7 @@ func TestAltKeyring_ImportExportPubKey(t *testing.T) { } func TestAltKeyring_ImportExportPubKey_ByAddress(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) - - keyring, err := New(t.Name(), BackendTest, dir, nil) + keyring, err := New(t.Name(), BackendTest, t.TempDir(), nil) require.NoError(t, err) uid := theID @@ -1140,10 +1086,7 @@ func TestAltKeyring_ImportExportPubKey_ByAddress(t *testing.T) { } func TestAltKeyring_ConstructorSupportedAlgos(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) - - keyring, err := New(t.Name(), BackendTest, dir, nil) + keyring, err := New(t.Name(), BackendTest, t.TempDir(), nil) require.NoError(t, err) // should fail when using unsupported signing algorythm. @@ -1155,10 +1098,7 @@ func TestAltKeyring_ConstructorSupportedAlgos(t *testing.T) { require.NoError(t, err) // but we can create a new keybase with our provided algos. - dir2, clean2 := testutil.NewTestCaseDir(t) - t.Cleanup(clean2) - - keyring2, err := New(t.Name(), BackendTest, dir2, nil, func(options *Options) { + keyring2, err := New(t.Name(), BackendTest, t.TempDir(), nil, func(options *Options) { options.SupportedAlgos = SigningAlgoList{ notSupportedAlgo{}, } diff --git a/crypto/keyring/legacy_test.go b/crypto/keyring/legacy_test.go index 38457a32732f..27503bdea056 100644 --- a/crypto/keyring/legacy_test.go +++ b/crypto/keyring/legacy_test.go @@ -9,20 +9,18 @@ import ( "github.com/stretchr/testify/require" "github.com/cosmos/cosmos-sdk/crypto/keyring" - "github.com/cosmos/cosmos-sdk/testutil" ) func TestNewLegacyKeyBase(t *testing.T) { - dir, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) + dir := t.TempDir() + kb, err := keyring.NewLegacy("keybasename", dir) require.NoError(t, err) require.NoError(t, kb.Close()) } func TestLegacyKeybase(t *testing.T) { - dir, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) + dir := t.TempDir() // Backup testdata require.NoError(t, copy.Copy("testdata", dir)) diff --git a/go.mod b/go.mod index f814563aa737..aca0bcb93dba 100644 --- a/go.mod +++ b/go.mod @@ -1,4 +1,4 @@ -go 1.14 +go 1.15 module github.com/cosmos/cosmos-sdk diff --git a/go.sum b/go.sum index 726e17c3b9b0..73e17473b177 100644 --- a/go.sum +++ b/go.sum @@ -514,8 +514,6 @@ github.com/tendermint/tendermint v0.33.2 h1:NzvRMTuXJxqSsFed2J7uHmMU5N1CVzSpfi3n github.com/tendermint/tendermint v0.33.2/go.mod h1:25DqB7YvV1tN3tHsjWoc2vFtlwICfrub9XO6UBO+4xk= github.com/tendermint/tendermint v0.33.5 h1:jYgRd9ImkzA9iOyhpmgreYsqSB6tpDa6/rXYPb8HKE8= github.com/tendermint/tendermint v0.33.5/go.mod h1:0yUs9eIuuDq07nQql9BmI30FtYGcEC60Tu5JzB5IezM= -github.com/tendermint/tendermint v0.33.7 h1:b5CQD8ggDtl4u0EbXzabi0MaOw9NrcXker6ijEkAE74= -github.com/tendermint/tendermint v0.33.7/go.mod h1:0yUs9eIuuDq07nQql9BmI30FtYGcEC60Tu5JzB5IezM= github.com/tendermint/tendermint v0.33.8 h1:Xxu4QhpqcomSE0iQDw1MqLgfsa8fqtPtWFJK6zZOVso= github.com/tendermint/tendermint v0.33.8/go.mod h1:0yUs9eIuuDq07nQql9BmI30FtYGcEC60Tu5JzB5IezM= github.com/tendermint/tm-db v0.4.1/go.mod h1:JsJ6qzYkCGiGwm5GHl/H5GLI9XLb6qZX7PRe425dHAY= diff --git a/server/constructors_test.go b/server/constructors_test.go index 694f9f538492..c131c2c987de 100644 --- a/server/constructors_test.go +++ b/server/constructors_test.go @@ -5,23 +5,18 @@ import ( "testing" "github.com/stretchr/testify/require" - - "github.com/cosmos/cosmos-sdk/testutil" ) func Test_openDB(t *testing.T) { t.Parallel() - dir, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) - _, err := openDB(dir) + _, err := openDB(t.TempDir()) require.NoError(t, err) } func Test_openTraceWriter(t *testing.T) { t.Parallel() - dir, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) - fname := filepath.Join(dir, "logfile") + + fname := filepath.Join(t.TempDir(), "logfile") w, err := openTraceWriter(fname) require.NoError(t, err) require.NotNil(t, w) diff --git a/server/export_test.go b/server/export_test.go index 585807812655..a34ace616e0b 100644 --- a/server/export_test.go +++ b/server/export_test.go @@ -20,14 +20,12 @@ import ( "github.com/cosmos/cosmos-sdk/client" "github.com/cosmos/cosmos-sdk/client/flags" "github.com/cosmos/cosmos-sdk/simapp" - "github.com/cosmos/cosmos-sdk/testutil" "github.com/cosmos/cosmos-sdk/types/errors" "github.com/cosmos/cosmos-sdk/x/genutil" ) func TestExportCmd_ConsensusParams(t *testing.T) { - tempDir, clean := testutil.NewTestCaseDir(t) - defer clean() + tempDir := t.TempDir() err := createConfigFolder(tempDir) if err != nil { diff --git a/server/init_test.go b/server/init_test.go index 2333d6d5a0d3..87e83cf21878 100644 --- a/server/init_test.go +++ b/server/init_test.go @@ -8,7 +8,6 @@ import ( "github.com/cosmos/cosmos-sdk/crypto/hd" "github.com/cosmos/cosmos-sdk/crypto/keyring" "github.com/cosmos/cosmos-sdk/server" - "github.com/cosmos/cosmos-sdk/testutil" "github.com/cosmos/cosmos-sdk/types" ) @@ -25,10 +24,8 @@ func TestGenerateCoinKey(t *testing.T) { func TestGenerateSaveCoinKey(t *testing.T) { t.Parallel() - dir, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) - kb, err := keyring.New(t.Name(), "test", dir, nil) + kb, err := keyring.New(t.Name(), "test", t.TempDir(), nil) require.NoError(t, err) addr, mnemonic, err := server.GenerateSaveCoinKey(kb, "keyname", "012345678", false) @@ -47,10 +44,8 @@ func TestGenerateSaveCoinKey(t *testing.T) { func TestGenerateSaveCoinKeyOverwriteFlag(t *testing.T) { t.Parallel() - dir, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) - kb, err := keyring.New(t.Name(), "test", dir, nil) + kb, err := keyring.New(t.Name(), "test", t.TempDir(), nil) require.NoError(t, err) keyname := "justakey" diff --git a/testutil/ioutil.go b/testutil/ioutil.go index 0df67fd35da1..9a5c697f885d 100644 --- a/testutil/ioutil.go +++ b/testutil/ioutil.go @@ -12,15 +12,6 @@ import ( "github.com/stretchr/testify/require" ) -// NewTestCaseDir creates a new temporary directory for a test case. -// Returns the directory path and a cleanup function. -// nolint: errcheck -func NewTestCaseDir(t testing.TB) (string, func()) { - dir, err := ioutil.TempDir("", strings.ReplaceAll(t.Name(), "/", "_")+"_") - require.NoError(t, err) - return dir, func() { os.RemoveAll(dir) } -} - // BufferReader is implemented by types that read from a string buffer. type BufferReader interface { io.Reader diff --git a/testutil/ioutil_test.go b/testutil/ioutil_test.go index 272ff323b321..4a05fb08dcb2 100644 --- a/testutil/ioutil_test.go +++ b/testutil/ioutil_test.go @@ -10,23 +10,6 @@ import ( "github.com/cosmos/cosmos-sdk/testutil" ) -func TestNewTestCaseDir(t *testing.T) { - dir1, cleanup1 := testutil.NewTestCaseDir(t) - dir2, cleanup2 := testutil.NewTestCaseDir(t) - - require.NotEqual(t, dir1, dir2) - require.DirExists(t, dir1) - require.DirExists(t, dir2) - - cleanup1() - - require.NoDirExists(t, dir1) - require.DirExists(t, dir2) - - cleanup2() - require.NoDirExists(t, dir2) -} - func TestApplyMockIO(t *testing.T) { cmd := &cobra.Command{} oldStdin := cmd.InOrStdin() diff --git a/x/auth/client/cli/cli_test.go b/x/auth/client/cli/cli_test.go index dd879de6ad82..7676bb67ec81 100644 --- a/x/auth/client/cli/cli_test.go +++ b/x/auth/client/cli/cli_test.go @@ -649,9 +649,7 @@ func TestGetBroadcastCommand_WithoutOfflineFlag(t *testing.T) { cmd := authcli.GetBroadcastCommand() _, out := testutil.ApplyMockIO(cmd) - - testDir, cleanFunc := testutil.NewTestCaseDir(t) - t.Cleanup(cleanFunc) + testDir := t.TempDir() // Create new file with tx builder := txCfg.NewTxBuilder() diff --git a/x/genutil/client/cli/gentx_test.go b/x/genutil/client/cli/gentx_test.go index 3153afb39b1a..aa452740a28b 100644 --- a/x/genutil/client/cli/gentx_test.go +++ b/x/genutil/client/cli/gentx_test.go @@ -47,10 +47,7 @@ func (s *IntegrationTestSuite) TearDownSuite() { func (s *IntegrationTestSuite) TestGenTxCmd() { val := s.network.Validators[0] - - dir, clean := testutil.NewTestCaseDir(s.T()) - defer clean() - + dir := s.T().TempDir() cmd := GenTxCmd( simapp.ModuleBasics, val.ClientCtx.TxConfig, banktypes.GenesisBalancesIterator{}, val.ClientCtx.HomeDir) diff --git a/x/genutil/client/cli/init_test.go b/x/genutil/client/cli/init_test.go index a0e2bc5f136f..25221d966c3c 100644 --- a/x/genutil/client/cli/init_test.go +++ b/x/genutil/client/cli/init_test.go @@ -21,7 +21,6 @@ import ( cryptocodec "github.com/cosmos/cosmos-sdk/crypto/codec" "github.com/cosmos/cosmos-sdk/server" "github.com/cosmos/cosmos-sdk/server/mock" - "github.com/cosmos/cosmos-sdk/testutil" sdk "github.com/cosmos/cosmos-sdk/types" "github.com/cosmos/cosmos-sdk/types/module" "github.com/cosmos/cosmos-sdk/x/genutil" @@ -64,10 +63,9 @@ func TestInitCmd(t *testing.T) { for _, tt := range tests { tt := tt t.Run(tt.name, func(t *testing.T) { - home, cleanup := testutil.NewTestCaseDir(t) - defer cleanup() - + home := t.TempDir() logger := log.NewNopLogger() + cfg, err := createDefaultTendermintConfig(home) require.NoError(t, err) @@ -94,18 +92,10 @@ func TestInitCmd(t *testing.T) { } -func setupClientHome(t *testing.T) func() { - _, cleanup := testutil.NewTestCaseDir(t) - return cleanup -} - func TestEmptyState(t *testing.T) { - t.Cleanup(setupClientHome(t)) - - home, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) - + home := t.TempDir() logger := log.NewNopLogger() + cfg, err := createDefaultTendermintConfig(home) require.NoError(t, err) @@ -148,12 +138,10 @@ func TestEmptyState(t *testing.T) { } func TestStartStandAlone(t *testing.T) { - home, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) - t.Cleanup(setupClientHome(t)) - + home := t.TempDir() logger := log.NewNopLogger() cfg, err := createDefaultTendermintConfig(home) + require.NoError(t, err) serverCtx := server.NewContext(viper.New(), cfg, logger) @@ -190,10 +178,10 @@ func TestStartStandAlone(t *testing.T) { } func TestInitNodeValidatorFiles(t *testing.T) { - home, cleanup := testutil.NewTestCaseDir(t) + home := t.TempDir() cfg, err := createDefaultTendermintConfig(home) - t.Cleanup(cleanup) nodeID, valPubKey, err := genutil.InitializeNodeValidatorFiles(cfg) + require.Nil(t, err) require.NotEqual(t, "", nodeID) require.NotEqual(t, 0, len(valPubKey.Bytes())) diff --git a/x/genutil/client/cli/migrate_test.go b/x/genutil/client/cli/migrate_test.go index d5d35754ee9c..9dcee12bdd52 100644 --- a/x/genutil/client/cli/migrate_test.go +++ b/x/genutil/client/cli/migrate_test.go @@ -19,8 +19,7 @@ func TestGetMigrationCallback(t *testing.T) { } func TestMigrateGenesis(t *testing.T) { - home, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) + home := t.TempDir() cdc := makeCodec() diff --git a/x/genutil/utils_test.go b/x/genutil/utils_test.go index bf8cf9f5d0ac..3a45addb9ebd 100644 --- a/x/genutil/utils_test.go +++ b/x/genutil/utils_test.go @@ -6,16 +6,13 @@ import ( "testing" "time" - "github.com/cosmos/cosmos-sdk/testutil" - "github.com/stretchr/testify/require" ) func TestExportGenesisFileWithTime(t *testing.T) { t.Parallel() - dir, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) - fname := filepath.Join(dir, "genesis.json") + fname := filepath.Join(t.TempDir(), "genesis.json") + require.NoError(t, ExportGenesisFileWithTime(fname, "test", nil, json.RawMessage(""), time.Now())) } diff --git a/x/upgrade/types/storeloader_test.go b/x/upgrade/types/storeloader_test.go index a77b7593e288..592fd477eee6 100644 --- a/x/upgrade/types/storeloader_test.go +++ b/x/upgrade/types/storeloader_test.go @@ -15,7 +15,6 @@ import ( "github.com/cosmos/cosmos-sdk/baseapp" "github.com/cosmos/cosmos-sdk/store/rootmulti" store "github.com/cosmos/cosmos-sdk/store/types" - "github.com/cosmos/cosmos-sdk/testutil" sdk "github.com/cosmos/cosmos-sdk/types" ) @@ -66,15 +65,15 @@ func checkStore(t *testing.T, db dbm.DB, ver int64, storeKey string, k, v []byte // Test that LoadLatestVersion actually does. func TestSetLoader(t *testing.T) { // set a temporary home dir - homeDir, cleanup := testutil.NewTestCaseDir(t) - t.Cleanup(cleanup) - + homeDir := t.TempDir() upgradeInfoFilePath := filepath.Join(homeDir, "upgrade-info.json") upgradeInfo := &store.UpgradeInfo{ Name: "test", Height: 0, } + data, err := json.Marshal(upgradeInfo) require.NoError(t, err) + err = ioutil.WriteFile(upgradeInfoFilePath, data, 0644) require.NoError(t, err) From 5e2557edc2f88a5ce7b87cf24a4109b5bff0f057 Mon Sep 17 00:00:00 2001 From: Alessio Treglia Date: Wed, 12 Aug 2020 16:43:16 +0100 Subject: [PATCH 2/8] remove use of ioutil.TempDir() --- x/upgrade/keeper/keeper_test.go | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/x/upgrade/keeper/keeper_test.go b/x/upgrade/keeper/keeper_test.go index 7ede1c65dfdf..3047b1004c71 100644 --- a/x/upgrade/keeper/keeper_test.go +++ b/x/upgrade/keeper/keeper_test.go @@ -1,8 +1,8 @@ package keeper_test import ( - "io/ioutil" "os" + "path/filepath" "testing" "github.com/stretchr/testify/suite" @@ -22,15 +22,10 @@ type KeeperTestSuite struct { func (s *KeeperTestSuite) SetupTest() { app := simapp.Setup(false) - - homeDir, err := ioutil.TempDir(os.TempDir(), "x_upgrade_keeper_test") - s.Require().NoError(err) - - // recreate keeper in order to use a custom home path - app.UpgradeKeeper = keeper.NewKeeper( + homeDir := filepath.Join(os.TempDir(), "x_upgrade_keeper_test") + app.UpgradeKeeper = keeper.NewKeeper( // recreate keeper in order to use a custom home path make(map[int64]bool), app.GetKey(types.StoreKey), app.AppCodec(), homeDir, ) - s.homeDir = homeDir s.app = app } From 587351e711257bbd8450a15f41e3b62b38fe1497 Mon Sep 17 00:00:00 2001 From: Alessio Treglia Date: Thu, 13 Aug 2020 14:18:02 +0100 Subject: [PATCH 3/8] upgrade to go 1.15 --- .github/workflows/tag.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tag.yml b/.github/workflows/tag.yml index 6040be79ca2e..1cf9a3353c84 100644 --- a/.github/workflows/tag.yml +++ b/.github/workflows/tag.yml @@ -15,7 +15,7 @@ jobs: - name: Install Go uses: actions/setup-go@v1 with: - go-version: 1.14 + go-version: 1.15 - name: Unshallow run: git fetch --prune --unshallow - name: Create release From a297ff67c68352978b56dabbd37d5ab0340b31aa Mon Sep 17 00:00:00 2001 From: Marko Baricevic Date: Wed, 26 Aug 2020 14:57:38 +0200 Subject: [PATCH 4/8] findout go version --- .github/workflows/test.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 8afd74132e22..47230d15a067 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -23,7 +23,7 @@ jobs: id: git_diff with: PREFIX_FILTER: | - cosmovisor + cosmovisor SUFFIX_FILTER: | .go .mod @@ -63,6 +63,7 @@ jobs: timeout-minutes: 15 steps: - uses: actions/checkout@v2 + - run: go version - uses: technote-space/get-diff-action@v3 id: git_diff with: From 64fa2b641d4bca859aed4f7e9a5c4084734dba85 Mon Sep 17 00:00:00 2001 From: Alessio Treglia Date: Fri, 18 Sep 2020 10:28:59 +0100 Subject: [PATCH 5/8] ensure go 1.15 is picked up --- .github/workflows/test.yml | 55 +++++++++++++++++++++++++++++++++++++- 1 file changed, 54 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 144494054968..a55d28f3249f 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -19,6 +19,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/setup-go@v2.1.2 + with: + go-version: 1.15 + - name: Display go version + run: go version - name: install tparse run: | export GO111MODULE="on" && go get github.com/mfridman/tparse@v0.8.3 @@ -31,6 +35,11 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 + - uses: actions/setup-go@v2.1.2 + with: + go-version: 1.15 + - name: Display go version + run: go version - uses: technote-space/get-diff-action@v1 id: git_diff with: @@ -48,6 +57,11 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 + - uses: actions/setup-go@v2.1.2 + with: + go-version: 1.15 + - name: Display go version + run: go version - name: Create a file with all the pkgs run: go list ./... > pkgs.txt - name: Split pkgs into 4 files @@ -76,7 +90,11 @@ jobs: timeout-minutes: 15 steps: - uses: actions/checkout@v2 - - run: go version + - uses: actions/setup-go@v2.1.2 + with: + go-version: 1.15 + - name: Display go version + run: go version - uses: technote-space/get-diff-action@v3 id: git_diff with: @@ -114,6 +132,11 @@ jobs: timeout-minutes: 15 steps: - uses: actions/checkout@v2 + - uses: actions/setup-go@v2.1.2 + with: + go-version: 1.15 + - name: Display go version + run: go version - uses: technote-space/get-diff-action@v3 id: git_diff with: @@ -151,6 +174,11 @@ jobs: timeout-minutes: 15 steps: - uses: actions/checkout@v2 + - uses: actions/setup-go@v2.1.2 + with: + go-version: 1.15 + - name: Display go version + run: go version - uses: technote-space/get-diff-action@v3 id: git_diff with: @@ -188,6 +216,11 @@ jobs: timeout-minutes: 15 steps: - uses: actions/checkout@v2 + - uses: actions/setup-go@v2.1.2 + with: + go-version: 1.15 + - name: Display go version + run: go version - uses: technote-space/get-diff-action@v3 id: git_diff with: @@ -225,6 +258,11 @@ jobs: timeout-minutes: 15 steps: - uses: actions/checkout@v2 + - uses: actions/setup-go@v2.1.2 + with: + go-version: 1.15 + - name: Display go version + run: go version - uses: technote-space/get-diff-action@v3 id: git_diff with: @@ -250,6 +288,11 @@ jobs: timeout-minutes: 15 steps: - uses: actions/checkout@v2 + - uses: actions/setup-go@v2.1.2 + with: + go-version: 1.15 + - name: Display go version + run: go version - uses: technote-space/get-diff-action@v3 id: git_diff with: @@ -275,6 +318,11 @@ jobs: timeout-minutes: 15 steps: - uses: actions/checkout@v2 + - uses: actions/setup-go@v2.1.2 + with: + go-version: 1.15 + - name: Display go version + run: go version - uses: technote-space/get-diff-action@v3 id: git_diff with: @@ -300,6 +348,11 @@ jobs: timeout-minutes: 15 steps: - uses: actions/checkout@v2 + - uses: actions/setup-go@v2.1.2 + with: + go-version: 1.15 + - name: Display go version + run: go version - uses: technote-space/get-diff-action@v3 id: git_diff with: From ba2f8e3dd74c8b366081d18828ad1317ad162dab Mon Sep 17 00:00:00 2001 From: Alessio Treglia Date: Fri, 18 Sep 2020 10:38:41 +0100 Subject: [PATCH 6/8] use T.TempDir() everywhere --- client/tx/tx_test.go | 6 +----- server/export_test.go | 18 +++++------------- simapp/simd/cmd/genaccounts_test.go | 5 +---- 3 files changed, 7 insertions(+), 22 deletions(-) diff --git a/client/tx/tx_test.go b/client/tx/tx_test.go index 825b158c1430..41a021fef1b5 100644 --- a/client/tx/tx_test.go +++ b/client/tx/tx_test.go @@ -12,7 +12,6 @@ import ( "github.com/cosmos/cosmos-sdk/crypto/hd" "github.com/cosmos/cosmos-sdk/crypto/keyring" "github.com/cosmos/cosmos-sdk/simapp" - "github.com/cosmos/cosmos-sdk/testutil" sdk "github.com/cosmos/cosmos-sdk/types" "github.com/cosmos/cosmos-sdk/x/auth/signing" banktypes "github.com/cosmos/cosmos-sdk/x/bank/types" @@ -122,11 +121,8 @@ func TestBuildUnsignedTx(t *testing.T) { } func TestSign(t *testing.T) { - dir, clean := testutil.NewTestCaseDir(t) - t.Cleanup(clean) - path := hd.CreateHDPath(118, 0, 0).String() - kr, err := keyring.New(t.Name(), "test", dir, nil) + kr, err := keyring.New(t.Name(), "test", t.TempDir(), nil) require.NoError(t, err) var from = "test_sign" diff --git a/server/export_test.go b/server/export_test.go index 5212bf3e2902..ac0cf6b6596e 100644 --- a/server/export_test.go +++ b/server/export_test.go @@ -56,12 +56,10 @@ func TestExportCmd_ConsensusParams(t *testing.T) { } func TestExportCmd_HomeDir(t *testing.T) { - tempDir, clean := testutil.NewTestCaseDir(t) - defer clean() - - _, ctx, _, cmd := setupApp(t, tempDir) + _, ctx, _, cmd := setupApp(t, t.TempDir()) cmd.SetArgs([]string{fmt.Sprintf("--%s=%s", flags.FlagHome, "foobar")}) + err := cmd.ExecuteContext(ctx) require.EqualError(t, err, "stat foobar/config/genesis.json: no such file or directory") } @@ -96,9 +94,7 @@ func TestExportCmd_Height(t *testing.T) { for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) { - tempDir, clean := testutil.NewTestCaseDir(t) - defer clean() - + tempDir := t.TempDir() app, ctx, _, cmd := setupApp(t, tempDir) // Fast forward to block `tc.fastForward`. @@ -126,8 +122,7 @@ func TestExportCmd_Height(t *testing.T) { } func setupApp(t *testing.T, tempDir string) (*simapp.SimApp, context.Context, *tmtypes.GenesisDoc, *cobra.Command) { - err := createConfigFolder(tempDir) - if err != nil { + if err := createConfigFolder(tempDir); err != nil { t.Fatalf("error creating config folder: %s", err) } @@ -140,11 +135,9 @@ func setupApp(t *testing.T, tempDir string) (*simapp.SimApp, context.Context, *t serverCtx.Config.RootDir = tempDir clientCtx := client.Context{}.WithJSONMarshaler(app.AppCodec()) - genDoc := newDefaultGenesisDoc() - err = saveGenesisFile(genDoc, serverCtx.Config.GenesisFile()) - require.NoError(t, err) + require.NoError(t, saveGenesisFile(genDoc, serverCtx.Config.GenesisFile())) app.InitChain( abci.RequestInitChain{ Validators: []abci.ValidatorUpdate{}, @@ -152,7 +145,6 @@ func setupApp(t *testing.T, tempDir string) (*simapp.SimApp, context.Context, *t AppStateBytes: genDoc.AppState, }, ) - app.Commit() cmd := server.ExportCmd( diff --git a/simapp/simd/cmd/genaccounts_test.go b/simapp/simd/cmd/genaccounts_test.go index da980b7be173..9efc5343e7a3 100644 --- a/simapp/simd/cmd/genaccounts_test.go +++ b/simapp/simd/cmd/genaccounts_test.go @@ -14,7 +14,6 @@ import ( "github.com/cosmos/cosmos-sdk/server" "github.com/cosmos/cosmos-sdk/simapp" simcmd "github.com/cosmos/cosmos-sdk/simapp/simd/cmd" - "github.com/cosmos/cosmos-sdk/testutil" "github.com/cosmos/cosmos-sdk/testutil/testdata" "github.com/cosmos/cosmos-sdk/types/module" "github.com/cosmos/cosmos-sdk/x/genutil" @@ -54,9 +53,7 @@ func TestAddGenesisAccountCmd(t *testing.T) { for _, tc := range tests { tc := tc t.Run(tc.name, func(t *testing.T) { - home, cleanup := testutil.NewTestCaseDir(t) - defer cleanup() - + home := t.TempDir() logger := log.NewNopLogger() cfg, err := genutiltest.CreateDefaultTendermintConfig(home) require.NoError(t, err) From eb3f0100326755a11e038dc9593bc2f24224296e Mon Sep 17 00:00:00 2001 From: Alessio Treglia Date: Fri, 18 Sep 2020 11:15:40 +0100 Subject: [PATCH 7/8] use go 1.15 for simulations --- .github/workflows/sims.yml | 37 ++++++++++++++++++++++++++++++++----- 1 file changed, 32 insertions(+), 5 deletions(-) diff --git a/.github/workflows/sims.yml b/.github/workflows/sims.yml index e39407176d2e..52d6a41ae3c9 100644 --- a/.github/workflows/sims.yml +++ b/.github/workflows/sims.yml @@ -21,17 +21,24 @@ jobs: if: "!contains(github.event.head_commit.message, 'skip-sims')" steps: - uses: actions/checkout@v2 - - run: | - make build + - uses: actions/setup-go@v2.1.2 + with: + go-version: 1.15 + - name: Display go version + run: go version + - run: make build install-runsim: runs-on: ubuntu-latest needs: build steps: - uses: actions/setup-go@v2.1.2 - - name: install runsim - run: | - export GO111MODULE="on" && go get github.com/cosmos/tools/cmd/runsim@v1.0.0 + with: + go-version: 1.15 + - name: Display go version + run: go version + - name: Install runsim + run: export GO111MODULE="on" && go get github.com/cosmos/tools/cmd/runsim@v1.0.0 - uses: actions/cache@v2.1.1 with: path: ~/go/bin @@ -42,6 +49,11 @@ jobs: needs: [build, install-runsim] steps: - uses: actions/checkout@v2 + - uses: actions/setup-go@v2.1.2 + with: + go-version: 1.15 + - name: Display go version + run: go version - uses: technote-space/get-diff-action@v3 with: SUFFIX_FILTER: | @@ -65,6 +77,11 @@ jobs: needs: [build, install-runsim] steps: - uses: actions/checkout@v2 + - uses: actions/setup-go@v2.1.2 + with: + go-version: 1.15 + - name: Display go version + run: go version - uses: technote-space/get-diff-action@v3 with: SUFFIX_FILTER: | @@ -88,6 +105,11 @@ jobs: needs: [build, install-runsim] steps: - uses: actions/checkout@v2 + - uses: actions/setup-go@v2.1.2 + with: + go-version: 1.15 + - name: Display go version + run: go version - uses: technote-space/get-diff-action@v3 with: SUFFIX_FILTER: | @@ -111,6 +133,11 @@ jobs: needs: [build, install-runsim] steps: - uses: actions/checkout@v2 + - uses: actions/setup-go@v2.1.2 + with: + go-version: 1.15 + - name: Display go version + run: go version - uses: technote-space/get-diff-action@v3 with: SUFFIX_FILTER: | From 108e780a9c50eb7205b47c3ffe1c0e679ab6efcf Mon Sep 17 00:00:00 2001 From: Alessio Treglia Date: Fri, 18 Sep 2020 11:32:47 +0100 Subject: [PATCH 8/8] use *testing.T.TempDir() --- x/distribution/client/cli/cli_test.go | 7 ++----- x/gov/client/cli/cli_test.go | 7 ++----- x/upgrade/keeper/keeper_test.go | 4 ++-- 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/x/distribution/client/cli/cli_test.go b/x/distribution/client/cli/cli_test.go index 35b212a81e39..8b3f02db903f 100644 --- a/x/distribution/client/cli/cli_test.go +++ b/x/distribution/client/cli/cli_test.go @@ -6,7 +6,6 @@ import ( "context" "fmt" "io/ioutil" - "os" "strings" "testing" "time" @@ -687,9 +686,8 @@ func (s *IntegrationTestSuite) TestNewFundCommunityPoolCmd() { func (s *IntegrationTestSuite) TestGetCmdSubmitProposal() { val := s.network.Validators[0] - invalidPropFile, err := ioutil.TempFile(os.TempDir(), "invalid_community_spend_proposal.*.json") + invalidPropFile, err := ioutil.TempFile(s.T().TempDir(), "invalid_community_spend_proposal.*.json") s.Require().NoError(err) - defer os.Remove(invalidPropFile.Name()) invalidProp := `{ "title": "", @@ -702,9 +700,8 @@ func (s *IntegrationTestSuite) TestGetCmdSubmitProposal() { _, err = invalidPropFile.WriteString(invalidProp) s.Require().NoError(err) - validPropFile, err := ioutil.TempFile(os.TempDir(), "valid_community_spend_proposal.*.json") + validPropFile, err := ioutil.TempFile(s.T().TempDir(), "valid_community_spend_proposal.*.json") s.Require().NoError(err) - defer os.Remove(validPropFile.Name()) validProp := fmt.Sprintf(`{ "title": "Community Pool Spend", diff --git a/x/gov/client/cli/cli_test.go b/x/gov/client/cli/cli_test.go index 47bc19be9767..ab8b75741e86 100644 --- a/x/gov/client/cli/cli_test.go +++ b/x/gov/client/cli/cli_test.go @@ -5,7 +5,6 @@ package cli_test import ( "fmt" "io/ioutil" - "os" "testing" "github.com/gogo/protobuf/proto" @@ -47,9 +46,8 @@ func (s *IntegrationTestSuite) TearDownSuite() { func (s *IntegrationTestSuite) TestNewCmdSubmitProposal() { val := s.network.Validators[0] - invalidPropFile, err := ioutil.TempFile(os.TempDir(), "invalid_text_proposal.*.json") + invalidPropFile, err := ioutil.TempFile(s.T().TempDir(), "invalid_text_proposal.*.json") s.Require().NoError(err) - defer os.Remove(invalidPropFile.Name()) invalidProp := `{ "title": "", @@ -61,9 +59,8 @@ func (s *IntegrationTestSuite) TestNewCmdSubmitProposal() { _, err = invalidPropFile.WriteString(invalidProp) s.Require().NoError(err) - validPropFile, err := ioutil.TempFile(os.TempDir(), "valid_text_proposal.*.json") + validPropFile, err := ioutil.TempFile(s.T().TempDir(), "valid_text_proposal.*.json") s.Require().NoError(err) - defer os.Remove(validPropFile.Name()) validProp := fmt.Sprintf(`{ "title": "Text Proposal", diff --git a/x/upgrade/keeper/keeper_test.go b/x/upgrade/keeper/keeper_test.go index 3047b1004c71..3fa408ba212f 100644 --- a/x/upgrade/keeper/keeper_test.go +++ b/x/upgrade/keeper/keeper_test.go @@ -1,7 +1,6 @@ package keeper_test import ( - "os" "path/filepath" "testing" @@ -22,10 +21,11 @@ type KeeperTestSuite struct { func (s *KeeperTestSuite) SetupTest() { app := simapp.Setup(false) - homeDir := filepath.Join(os.TempDir(), "x_upgrade_keeper_test") + homeDir := filepath.Join(s.T().TempDir(), "x_upgrade_keeper_test") app.UpgradeKeeper = keeper.NewKeeper( // recreate keeper in order to use a custom home path make(map[int64]bool), app.GetKey(types.StoreKey), app.AppCodec(), homeDir, ) + s.T().Log("home dir:", homeDir) s.homeDir = homeDir s.app = app }