fix: overwrite sequence and account-number flags when used with offline=false#9856
Merged
Conversation
added 18 commits
July 8, 2021 14:54
…rn GasLeft on GasMeter
…khita/sequence-flag-ux-issue
…es when provided with offline != true
added 2 commits
August 5, 2021 15:02
|
Visit https://dashboard.github.orijtech.com?pr=9856&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
Codecov Report
@@ Coverage Diff @@
## master #9856 +/- ##
==========================================
+ Coverage 63.45% 63.46% +0.01%
==========================================
Files 568 568
Lines 53260 53275 +15
==========================================
+ Hits 33795 33812 +17
+ Misses 17543 17539 -4
- Partials 1922 1924 +2
|
added 2 commits
August 5, 2021 15:48
added 3 commits
August 6, 2021 13:11
…khita/sequence-flag-ux-issue
alexanderbez
reviewed
Aug 6, 2021
added 3 commits
August 6, 2021 19:54
…khita/sequence-flag-ux-issue
alexanderbez
approved these changes
Aug 6, 2021
atheeshp
reviewed
Aug 6, 2021
added 2 commits
August 6, 2021 20:29
…osmos/cosmos-sdk into likhita/sequence-flag-ux-issue
added 4 commits
August 7, 2021 13:08
…khita/sequence-flag-ux-issue
…khita/sequence-flag-ux-issue
…khita/sequence-flag-ux-issue
…khita/sequence-flag-ux-issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #9784
Overwrite --sequence and --account-number flags by default flag values, when used with offline=false in sign-batch command.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change