Fix keyring options in add command #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladjdk
approved these changes
Jun 2, 2025
mmsqe
added a commit
to mmsqe/evm
that referenced
this pull request
Jul 15, 2025
This reverts commit 4f9b8c2.
Closed
1 task
mmsqe
added a commit
to mmsqe/evm
that referenced
this pull request
Aug 6, 2025
This reverts commit 4f9b8c2.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 11, 2025
…multisign (#288) * Revert "Fix keyring options in add command (#196)" This reverts commit 4f9b8c2. * allow unsupported public key type when send from old multisign addr * Revert "Fix keyring options in add command (#196)" This reverts commit 4f9b8c2. * resolve multisign --------- Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>
zsystm
pushed a commit
to zsystm/evm
that referenced
this pull request
Nov 2, 2025
zsystm
pushed a commit
to zsystm/evm
that referenced
this pull request
Nov 2, 2025
…multisign (cosmos#288) * Revert "Fix keyring options in add command (cosmos#196)" This reverts commit a068a20. * allow unsupported public key type when send from old multisign addr * Revert "Fix keyring options in add command (cosmos#196)" This reverts commit a068a20. * resolve multisign --------- Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the keyring options in the add command to specify all of the keyring options. This means unsupported keyring backends no longer work when they were not intended to.
Closes: #38
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranchReviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleasedsection inCHANGELOG.md