feat: add limit for batch request and response size #249
Conversation
There was a problem hiding this comment.
Lgtm, thank you for the contribution.
Similar to other PRs, could you add a more thorough description here and in the issue of the problem and your solution? The reference was helpful for context, but the PR you referenced is different from the changes you made here.
mmsqe
changed the title
rpc/backend/call_tx.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| length := len(res.Ret) |
There was a problem hiding this comment.
I think you removed this by mistake in the latest commits :)
There was a problem hiding this comment.
revert the space, no change for this file
There was a problem hiding this comment.
Ahh, I see, the restriction is now happening on the geth side. Lgtm!
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
|
@mmsqe we have resolved this in the audit and the change will be integrated once published. Will close this PR once integrated |
|
@mmsqe this is fixed in 0.3 and will be added back onto |
|
@aljo242 just saw missing config for toml from main, not sure if it's intended |
|
Makes sense to have in the config - thank you! this was an oversight |
* feat: add limit for eth_call return value * align batch limit * add back space * add back space * resolve --------- Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>
3 participants
Description
batch-request-limitconfig to enforces the maximum number of requests per batch and prevents abuse by oversized batch requestsbatch-response-max-sizeconfig to allow server should reject the batch or truncate the response, returning an error or partial result indicating the response size limit was exceeded.Closes: #241, for test info
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranchReviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleasedsection inCHANGELOG.md