Skip to content

Conversation

@yihuang
Copy link
Contributor

@yihuang yihuang commented Jul 21, 2025

Description

there are not much breaking changes.

Closes: #341


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

@yihuang yihuang requested review from a team as code owners July 21, 2025 08:55
evmd/go.mod Outdated
github.com/cosmos/evm/evmd => ./evmd
// use Cosmos geth fork
github.com/ethereum/go-ethereum => github.com/cosmos/go-ethereum v1.15.11-cosmos-0
github.com/ethereum/go-ethereum => github.com/yihuang/go-ethereum v1.10.21-0.20250721081216-98795aa589d5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you upstream your changes to cosmos/go-ethereum? We would be happy to integrate

Copy link
Contributor Author

@yihuang yihuang Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to probably create a base release/1.16 branch first? Then I can create a PR to that branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yihuang I created https://github.com/cosmos/go-ethereum/tree/release/1.16 off of v1.16.2. Feel free to make a PR off of that :)

Copy link
Contributor Author

@yihuang yihuang Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aljo242
Copy link
Contributor

aljo242 commented Jul 21, 2025

@yihuang can you please link an existing github issue for this? If one does not exist, feel free to create one. We want to ensure that all PRs have an associated issue for context.

@yihuang
Copy link
Contributor Author

yihuang commented Jul 23, 2025

@yihuang can you please link an existing github issue for this? If one does not exist, feel free to create one. We want to ensure that all PRs have an associated issue for context.

done: #341

Copy link
Member

@vladjdk vladjdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after conflicts are resolved and we have the upcoming PR from @yihuang merged into https://github.com/cosmos/go-ethereum

update deps evmd

update deps
Copy link
Member

@vladjdk vladjdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you. Will merge this and update to the geth tag when we push that.

@vladjdk vladjdk enabled auto-merge August 7, 2025 16:07
@vladjdk vladjdk added this pull request to the merge queue Aug 7, 2025
Merged via the queue into cosmos:main with commit 60c8962 Aug 7, 2025
16 checks passed
zsystm pushed a commit to zsystm/evm that referenced this pull request Nov 2, 2025
* feat: update go-ethereum to 1.16

* update deps

update deps evmd

update deps

* update deps

* fix build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: update go-ethereum to 1.16

3 participants