Skip to content

Conversation

@cloudgray
Copy link
Contributor

@cloudgray cloudgray commented Nov 13, 2025

Description

Closes: #818

  • Separate test app interface for each test with necessary keeper getter
  • Let tests validate whether injected app implements specific app interface

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@cloudgray cloudgray changed the title Refactor/separate app interface refactor(test): separate app interface Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.23%. Comparing base (a48de71) to head (8b06dd6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
+ Coverage   64.94%   65.23%   +0.29%     
==========================================
  Files         317      317              
  Lines       21615    21612       -3     
==========================================
+ Hits        14037    14099      +62     
  Misses       6351     6351              
+ Partials     1227     1162      -65     

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cloudgray cloudgray changed the title refactor(test): separate app interface refactor(test): separate test app interface Nov 13, 2025
@cloudgray cloudgray marked this pull request as ready for review November 13, 2025 13:50
@cloudgray cloudgray requested a review from vladjdk November 13, 2025 13:51
@cloudgray cloudgray self-assigned this Nov 13, 2025
Copy link
Member

@vladjdk vladjdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small nit - this is great!!!

@aljo242 aljo242 added this pull request to the merge queue Nov 14, 2025
Merged via the queue into cosmos:main with commit ee23828 Nov 14, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate EvmApp interface per test

3 participants