Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump SDK to v0.47.13-ics-lsm #3078

Merged
merged 4 commits into from
Apr 23, 2024
Merged

chore(deps): bump SDK to v0.47.13-ics-lsm #3078

merged 4 commits into from
Apr 23, 2024

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Apr 22, 2024

Description

Closes: #XXXX

Bump SDK to v0.47.13-ics-lsm (includes fixes from v0.47.11). It also bumps CometBFT to v0.37.5.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

MSalopek
MSalopek previously approved these changes Apr 22, 2024
@MSalopek MSalopek dismissed their stale review April 22, 2024 13:20

Didin't run the code locally.

@MSalopek MSalopek self-requested a review April 22, 2024 15:52
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important note:

We needed to add a mod replace for golang.org/x/exp so cosmos-sdk v0.47 keeps working as expected.

// stick with compatible version or x/exp in v0.47.x line
// x/exp had a breaking change in further commits
golang.org/x/exp => golang.org/x/exp v0.0.0-20230711153332-06a737ee72cb

@mpoke mpoke merged commit 4d67e48 into main Apr 23, 2024
18 checks passed
@mpoke mpoke deleted the marius/bump-sdk branch April 23, 2024 07:13
mergify bot pushed a commit that referenced this pull request Apr 23, 2024
* bump SDK to v0.47.13-ics-lsm

* add changelog entries

* fix: add expo replace directive

---------

Co-authored-by: MSalopek <matija.salopek994@gmail.com>
(cherry picked from commit 4d67e48)

# Conflicts:
#	.changelog/v16.0.0/dependencies/3062-bump-sdk.md
#	.changelog/v16.0.0/dependencies/3078-bump-comet.md
#	.changelog/v16.0.0/dependencies/3078-bump-sdk.md
#	.changelog/v16.0.0/state-breaking/3062-bump-sdk.md
#	go.mod
#	go.sum
mpoke added a commit that referenced this pull request Apr 23, 2024
* chore(deps): bump SDK to v0.47.13-ics-lsm (#3078)

* bump SDK to v0.47.13-ics-lsm

* add changelog entries

* fix: add expo replace directive

---------

Co-authored-by: MSalopek <matija.salopek994@gmail.com>
(cherry picked from commit 4d67e48)

# Conflicts:
#	.changelog/v16.0.0/dependencies/3062-bump-sdk.md
#	.changelog/v16.0.0/dependencies/3078-bump-comet.md
#	.changelog/v16.0.0/dependencies/3078-bump-sdk.md
#	.changelog/v16.0.0/state-breaking/3062-bump-sdk.md
#	go.mod
#	go.sum

* fix changelog

* fix changelog

* fix conflict

---------

Co-authored-by: Marius Poke <marius.poke@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants