Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifier Validation #262

Merged
merged 4 commits into from Sep 12, 2019

Conversation

@mossid
Copy link
Collaborator

commented Sep 11, 2019

Closes: #252

mossid added 3 commits Sep 11, 2019

@mossid mossid marked this pull request as ready for review Sep 11, 2019

@cwgoes cwgoes changed the title Identifier Validators Identifier Validation Sep 12, 2019

@cwgoes
Copy link
Collaborator

left a comment

Concept ACK, a few nits.

spec/ics-002-client-semantics/README.md Outdated Show resolved Hide resolved
spec/ics-002-client-semantics/README.md Outdated Show resolved Hide resolved
spec/ics-003-connection-semantics/README.md Outdated Show resolved Hide resolved
spec/ics-003-connection-semantics/README.md Outdated Show resolved Hide resolved
spec/ics-003-connection-semantics/README.md Outdated Show resolved Hide resolved
spec/ics-004-channel-and-packet-semantics/README.md Outdated Show resolved Hide resolved
spec/ics-003-connection-semantics/README.md Outdated Show resolved Hide resolved
spec/ics-002-client-semantics/README.md Outdated Show resolved Hide resolved
spec/ics-005-port-allocation/README.md Outdated Show resolved Hide resolved
spec/ics-005-port-allocation/README.md Outdated Show resolved Hide resolved

@cwgoes cwgoes added this to the IBC Specification 1.0.0-rc4 milestone Sep 12, 2019

Apply suggestions from code review
Co-Authored-By: Christopher Goes <cwgoes@pluranimity.org>
@cwgoes
cwgoes approved these changes Sep 12, 2019
Copy link
Collaborator

left a comment

ACK

@cwgoes cwgoes merged commit 8b000f0 into master Sep 12, 2019

6 checks passed

ci/circleci: check_dependencies Your tests passed on CircleCI!
Details
ci/circleci: check_links Your tests passed on CircleCI!
Details
ci/circleci: check_proto Your tests passed on CircleCI!
Details
ci/circleci: check_sections Your tests passed on CircleCI!
Details
ci/circleci: check_syntax Your tests passed on CircleCI!
Details
ci/circleci: spellcheck Your tests passed on CircleCI!
Details

@cwgoes cwgoes deleted the joon/252-identifier-validation branch Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.