Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle list of directories in $GOPATH #32

Closed
fiorix opened this issue Jul 15, 2018 · 1 comment · Fixed by #33
Closed

Handle list of directories in $GOPATH #32

fiorix opened this issue Jul 15, 2018 · 1 comment · Fixed by #33
Assignees
@cosmos72
Labels
bug

Comments

@fiorix
Copy link
Contributor

fiorix commented Jul 15, 2018

When $GOPATH is a list, import statements in gomacro create erroneous directories in the filesystem. For example, /a:/b:/c/gomacro_imports/{pkg}.

I have a PR for this with more details.
@fiorix fiorix mentioned this issue Jul 15, 2018
Merged
@cosmos72 cosmos72 self-assigned this Jul 15, 2018
@cosmos72 cosmos72 added the bug label Jul 15, 2018
@cosmos72
Copy link
Owner

Thanks! I will review it as soon as possible

cosmos72 added a commit that referenced this issue Jul 16, 2018
@cosmos72
further improve fix to #32
a019939
cosmos72 added a commit that referenced this issue Jul 16, 2018
@cosmos72
backport fix to #32 contributed by @fiorix
d488646
cosmos72 added a commit to gopherdata/gophernotes that referenced this issue Jul 16, 2018
@cosmos72
update vendored gomacro to fix #132 (copy of cosmos72/gomacro#32) and c…
88d4c00 
…osmos72/gomacro#34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cosmos72 cosmos72

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle list of directories in $GOPATH
2 participants
@fiorix @cosmos72