Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update search page #851

Merged
merged 6 commits into from Aug 17, 2019

Conversation

@tcgriffith
Copy link
Contributor

commented Aug 8, 2019

之前在cos讨论过,地址 https://d.cosx.org/d/420609

主要改进:

@XiangyunHuang XiangyunHuang requested a review from yixuan Aug 8, 2019

@XiangyunHuang

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

@tcgriffith 很赞呢!不过搜索框是不是还是保持之前的样子会好看点

@tcgriffith

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

确实css还没细调,尝试了algolia的css发现跟主站风格差的有点大就没用

@Lchiffon

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

@tcgriffith 谢谢你的PR,关于earchOnEnterKeyPressOnly: true可能需要讨论下,它看起来会让搜索变得更加快速,但是还是有些代价的

当时把这个功能关掉的主要原因是因为担心该功能打开会快速的耗尽我们aloglia免费账号的查询次数限制,比如08/08哪怕只是一个pr的版本,也会比平时用掉更多的查询:
image

不过我们目前的查询次数每天其实也不多, 或许我们可以在8月中旬开起来试一试,崩掉的话, 我们再关上....

@tcgriffith

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

查了一下免费帐号每个月operations上限是50K,不算更新index的话相当于一天1.6K的搜索,即使开了也是绰绰有余,作为参考,我那个日访问800的站每月最高也只用了1/10 ~ 1/5的免费流量(最高15K也不到1/3),看你的记录里每天查询量应该不超过两位数,目测没问题w

谨慎起见测个一两周呗,不过不知道流量用光algolia会怎么处理…

Screenshot from 2019-08-09 11-21-18

https://www.algolia.com/pricing/

@fyears

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

@Lchiffon 非免费套餐似乎有点贵啊……

@tcgriffith

This comment has been minimized.

Copy link
Contributor Author

commented Aug 11, 2019

调了CSS 关了search as your type

@yihui

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

初始页面是否可以不显示页面列表啊(就像当前版本的搜索一样:https://cosx.org/search/)。还没搜的时候就出来一批结果感觉不太对。

@XiangyunHuang

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

我觉得可以有默认列表,就像某些APP一样,但是内容应该是高密度价值的好文章,毕竟占据了很重要的位置,统计之都有很多经典好看的,可以随机展示一些

@yihui

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

如果能做到那样,我也没意见。

@XiangyunHuang

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

我把 @tcgriffith 给的新搜索页链接放在这里,不用每次去论坛了

@tcgriffith

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

改了, query为空时啥都不显示,与原来保持一致,@XiangyunHuang 提到的经典文章这个还需要先定义“经典文章”,以后再考虑吧www

@tcgriffith

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

我把 @tcgriffith 给的新搜索页链接放在这里,不用每次去论坛了

啊你没发现那个netlify的链接就在下面的all checks have passed里面吗 哈哈哈哈

@XiangyunHuang

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

@tcgriffith👍 它相当于另一个问题

@XiangyunHuang XiangyunHuang removed the request for review from yixuan Aug 12, 2019

@XiangyunHuang

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

@XiangyunHuang XiangyunHuang merged commit 8c3c910 into cosname:master Aug 17, 2019

1 check passed

deploy/netlify Deploy preview ready!
Details
@XiangyunHuang

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

我合并了

@tcgriffith tcgriffith deleted the tcgriffith:tc_search branch Aug 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.